Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notice in content search plugin #5423

Merged
merged 1 commit into from Dec 17, 2014
Merged

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Dec 14, 2014

During #5276 I changed from catslug to catid in the call to ContentHelperRoute::getArticleRoute(). Unfortunately, we don't retrieve the catid from the database. That is why we get a notice here.

Testinstructions

Search something in your Joomla installation and make sure that you have the content search plugin enabled. Notice the notice in the output for every content link.
Apply the change, see the notice disappear.

Thanks @shur for spotting this bug.

@shur
Copy link
Contributor

shur commented Dec 14, 2014

@Hackwar

tested, all works fine now!

@waader
Copy link
Contributor

waader commented Dec 15, 2014

@test works!

@zero-24
Copy link
Member

zero-24 commented Dec 15, 2014

RTC Thanks too all!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5423.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Dec 15, 2014
wilsonge added a commit that referenced this pull request Dec 17, 2014
Fix notice in content search plugin
@wilsonge wilsonge merged commit d27dc54 into joomla:staging Dec 17, 2014
@wilsonge
Copy link
Contributor

Thanks Hannes! Merged

@wilsonge wilsonge added this to the Joomla! 3.4.0 milestone Dec 17, 2014
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@Hackwar Hackwar deleted the patch-3 branch January 6, 2016 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants