[REFACTORING] Removing unnecessary trim in mod_languages #5950
Conversation
Confirmed. Trim is indeed not necessary. @test - everything works fine! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950. |
I have tested this item Jan This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950. |
Thank you @Hackwar and testers! Will be merged... ;-) |
I have tested this item This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This trim is not necessary. It does not remove any UTF8 characters and multiple spaces in HTML are always contracted into one space. At the same time, the p-tag around the text lets the space vanish completely. This is simply an unnecessary function call and in worst case forces the JString library to be loaded where it doesn't have to be.