New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTORING] Removing unnecessary trim in mod_languages #5950

Closed
wants to merge 1 commit into
base: staging
from

Conversation

Projects
None yet
7 participants
@Hackwar
Member

Hackwar commented Feb 2, 2015

This trim is not necessary. It does not remove any UTF8 characters and multiple spaces in HTML are always contracted into one space. At the same time, the p-tag around the text lets the space vanish completely. This is simply an unnecessary function call and in worst case forces the JString library to be loaded where it doesn't have to be.

@vdespa

This comment has been minimized.

Contributor

vdespa commented Mar 14, 2015

Confirmed. Trim is indeed not necessary. @test - everything works fine!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950.

@joomla-cms-bot joomla-cms-bot changed the title from Removing unnecessary trim in mod_languages to [REFACTORING] Removing unnecessary trim in mod_languages Mar 14, 2015

@PhocaCz

This comment has been minimized.

PhocaCz commented Oct 24, 2015

I have tested this item successfully on 226ffe5

Hi, testing now, confirmed, this is not needed there, it works OK.

Jan


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950.

@Kubik-Rubik Kubik-Rubik added the RTC label Oct 24, 2015

@joomla-cms-bot joomla-cms-bot removed the RTC label Oct 24, 2015

@Kubik-Rubik Kubik-Rubik added this to the Joomla! 3.4.6 milestone Oct 24, 2015

@Kubik-Rubik

This comment has been minimized.

Member

Kubik-Rubik commented Oct 24, 2015

Thank you @Hackwar and testers! Will be merged... ;-)

@Kubik-Rubik

This comment has been minimized.

Member

Kubik-Rubik commented Oct 24, 2015

I have tested this item successfully on 226ffe5

vdespa tested this item successfully!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5950.

@Kubik-Rubik

This comment has been minimized.

Member

Kubik-Rubik commented Oct 24, 2015

Thank you @Hackwar. Solved conflicts and merged with: a279c04

@zero-24 zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0 Oct 28, 2015

@Hackwar Hackwar deleted the Hackwar:patch-18 branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment