Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a class_exists check to PDO MySQL driver #6175

Merged
merged 1 commit into from Feb 26, 2015

Conversation

@mbabker
Copy link
Member

commented Feb 25, 2015

There are some reports in the forum about users getting a "class 'PDO' not found" error post upgrade. This appears to be due to calling a PDO class method which may not be present if PDO isn't supported, so this adds a class_exists check before that call.

@stresskills

This comment has been minimized.

Copy link

commented Feb 26, 2015

Thank you! fixed it for me. Any idea why this happened. I don't know much about PDO.

@mbabker

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2015

Thank you! fixed it for me. Any idea why this happened. I don't know much about PDO.

We added support for PDO based connections for MySQL. But, it's an extension that isn't always compiled with PHP. We simply forgot to add a check for it before trying to run code from the class, and it's something that slipped by while testing (apparently all testing was in environments that have the extension).

@ikark

This comment has been minimized.

Copy link

commented Feb 26, 2015

Worked for me too. Thanks

@stresskills

This comment has been minimized.

Copy link

commented Feb 26, 2015

We added support for PDO based connections for MySQL. But, it's an extension that isn't always compiled with PHP. We simply forgot to add a check for it before trying to run code from the class, and it's something that slipped by while testing (apparently all testing was in environments that have the extension).

Thank you for your response. I will add PDO to my server. I know my friend has been telling me the benefits. I guess time to look into it. Have a great day!

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2015

Multiple good tests. Merged

wilsonge added a commit that referenced this pull request Feb 26, 2015
Merge pull request #6175 from mbabker/PDOcheck
Add a class_exists check to PDO MySQL driver

@wilsonge wilsonge merged commit cb19ae9 into joomla:staging Feb 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilsonge wilsonge added this to the Joomla! 3.4.1 milestone Feb 26, 2015

@mbabker mbabker deleted the mbabker:PDOcheck branch Feb 26, 2015

@8of

This comment has been minimized.

Copy link

commented Mar 20, 2015

Works like a charm. Thanks.

@xillibit xillibit referenced this pull request Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.