Remove usage of JRouter from Languagefilter Plugin constructor #6278
Conversation
In truth, I think we need to remove the dependency on the language filter plugin from |
Notice: Use of undefined constant JROUTER_MODE_SEF - assumed 'JROUTER_MODE_SEF' in /plugins/system/languagefilter/languagefilter.php on line 58 |
Fixed. |
@test Tested on a site with Falang and wrorks4me. Thanks Hannes |
This was referenced Mar 9, 2015
wilsonge
added a commit
that referenced
this pull request
Mar 9, 2015
Remove usage of JRouter from Languagefilter Plugin constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In light of the issues that Falang had recently, this PR removes the usage of the router from the constructor, thus giving plugins like Falangs the chance to do their thing.