Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of JRouter from Languagefilter Plugin constructor #6278

Merged
merged 2 commits into from Mar 9, 2015

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 3, 2015

In light of the issues that Falang had recently, this PR removes the usage of the router from the constructor, thus giving plugins like Falangs the chance to do their thing.

@mbabker
Copy link
Contributor

mbabker commented Mar 3, 2015

In truth, I think we need to remove the dependency on the language filter plugin from JApplicationSite::initialiseApp(). This constructor is triggered long before the rest of the system plugins are imported for the onAfterInitialise event and I'm not seeing anything in the plugin that makes this dependency a requirement.

@Hackwar
Copy link
Member Author

Hackwar commented Mar 3, 2015

@mbabker not anymore. This was made possible by #5140. I didn't know that there was this special code in JApplicationSite to do this. But that wont change the issue, just make it harder to detect. So this PR is a good step forward.

@infograf768
Copy link
Member

Notice: Use of undefined constant JROUTER_MODE_SEF - assumed 'JROUTER_MODE_SEF' in /plugins/system/languagefilter/languagefilter.php on line 58

@Hackwar
Copy link
Member Author

Hackwar commented Mar 4, 2015

Fixed.

@gwsdesk
Copy link

gwsdesk commented Mar 8, 2015

@test Tested on a site with Falang and wrorks4me. Thanks Hannes

@infograf768 infograf768 added the RTC This Pull Request is Ready To Commit label Mar 9, 2015
@infograf768 infograf768 added this to the Joomla! 3.4.1 milestone Mar 9, 2015
wilsonge added a commit that referenced this pull request Mar 9, 2015
Remove usage of JRouter from Languagefilter Plugin constructor
@wilsonge wilsonge merged commit fd5eb39 into joomla:staging Mar 9, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@Hackwar Hackwar deleted the patch-35 branch January 6, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants