Improving JModuleHelper::getModule() test #6492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $module = JModuleHelper::getModule('mod_false'); | ||
|
|
||
| $this->assertTrue(is_object($module), 'No object was returned'); |
There was a problem hiding this comment.
Would it not be better to use assertInternalType for this?
|
Updated to use assertInternalType like @wilsonge proposed. |
wilsonge
added a commit
that referenced
this pull request
Mar 19, 2015
Improving JModuleHelper::getModule() test
|
FYI - this test has some incorrect language. There anonymous module should have no id should be: The anonymous module should have no id and There anonymous module should have the given name should be The anonymous module should have the given name |
|
@spignataro can you send a PR to fix them? https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests |
|
Done: #6572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title