New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving JModuleHelper::getModule() test #6492

Merged
merged 2 commits into from Mar 19, 2015

Conversation

Projects
None yet
5 participants
@Hackwar
Member

Hackwar commented Mar 18, 2015

See title

$module = JModuleHelper::getModule('mod_false');
$this->assertTrue(is_object($module), 'No object was returned');

This comment has been minimized.

@wilsonge

wilsonge Mar 18, 2015

Contributor

Would it not be better to use assertInternalType for this?

@Hackwar

This comment has been minimized.

Member

Hackwar commented Mar 19, 2015

Updated to use assertInternalType like @wilsonge proposed.

wilsonge added a commit that referenced this pull request Mar 19, 2015

Merge pull request #6492 from Hackwar/patch-45
Improving JModuleHelper::getModule() test

@wilsonge wilsonge merged commit 7e4a4c9 into joomla:staging Mar 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilsonge wilsonge added this to the Joomla! 3.4.1 milestone Mar 19, 2015

@spignataro

This comment has been minimized.

Contributor

spignataro commented Mar 22, 2015

FYI - this test has some incorrect language.

There anonymous module should have no id

should be:

The anonymous module should have no id

and

There anonymous module should have the given name

should be

The anonymous module should have the given name

@zero-24

This comment has been minimized.

Contributor

zero-24 commented Mar 22, 2015

@spignataro

This comment has been minimized.

Contributor

spignataro commented Mar 24, 2015

Done: #6572

@Hackwar Hackwar deleted the Hackwar:patch-45 branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment