New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing obsolete file check in JEditor #6513

Merged
merged 1 commit into from Apr 13, 2015

Conversation

Projects
None yet
7 participants
@Hackwar
Member

Hackwar commented Mar 20, 2015

The check that is removed in this PR was not valid since Joomla 1.6 and there is no way to install an editor in a way that this check would have evaluated to true. So this might as well be removed here and now.

@brianteeman

This comment has been minimized.

Contributor

brianteeman commented Mar 20, 2015

Applied patch and was still able to install JCE - is that a successful test?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6513.

@joomdonation

This comment has been minimized.

Contributor

joomdonation commented Mar 21, 2015

@brianteeman Make sure the editor is still being loaded properly (when you edit an article for example) and your test could be counted as one successful test.

@test : Look good from code review. Also applied the patch and editor still being loaded properly. So test success from me.

@Hackwar

This comment has been minimized.

Member

Hackwar commented Mar 21, 2015

@brianteeman as @joomdonation said, this is during loading of an editor. This check came from a time where plugins did not have their own folder, but were installed in the plugin groups folder directly. That is not possible anymore since 1.6 and thus this check can be removed.

@infograf768

This comment has been minimized.

Member

infograf768 commented Mar 21, 2015

Agree.

@brianteeman

This comment has been minimized.

Contributor

brianteeman commented Mar 21, 2015

Setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6513.

@brianteeman brianteeman added the RTC label Mar 21, 2015

@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Mar 21, 2015

wilsonge added a commit that referenced this pull request Apr 13, 2015

Merge pull request #6513 from Hackwar/patch-49
Removing obsolete file check in JEditor

@wilsonge wilsonge merged commit 5163b7e into joomla:staging Apr 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilsonge wilsonge modified the milestones: Joomla! 3.4.2, Joomla! 3.5.0 Apr 13, 2015

@zero-24 zero-24 removed the RTC label Oct 14, 2015

@Hackwar Hackwar deleted the Hackwar:patch-49 branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment