Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving JPluginHelper unittests #6550

Merged
merged 3 commits into from Mar 24, 2015
Merged

Improving JPluginHelper unittests #6550

merged 3 commits into from Mar 24, 2015

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 23, 2015

See title.

wilsonge
wilsonge reviewed Mar 23, 2015
View reviewed changes
tests/unit/suites/libraries/cms/plugin/JPluginHelperTest.php
@@ -99,6 +97,10 @@ public function testGetPlugin()
'loadmodule',
'plg_content_loadmodule should return loadmodule as the name'
);

$plugins = JPluginHelper::getPlugin('content');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put this into it's own test please :)

@wilsonge
Copy link
Contributor

👍

@Hackwar
Copy link
Member Author

Hackwar commented Mar 24, 2015

done

wilsonge added a commit that referenced this pull request Mar 24, 2015
@wilsonge
Merge pull request #6550 from Hackwar/patch-52
bed7b87 
Improving JPluginHelper unittests
@wilsonge wilsonge merged commit bed7b87 into joomla:staging Mar 24, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone Mar 26, 2015
@Hackwar Hackwar deleted the patch-52 branch January 6, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Unit/System Tests
Projects
None yet
Milestone
Joomla! 3.4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hackwar @wilsonge @brianteeman @joomla-cms-bot