Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clutter from the user list #6598

Closed
wants to merge 1 commit into from

Conversation

smehrbrodt
Copy link
Contributor

The user list looks quite cluttered with a button "Add a note" being below each user:

User list before

This change removes the text from that button (the text is still shown on a tooltip).

How to test:

Go to user manager. Without any notes attached to a user, it should look like this:

after

Then, add a note to a user. Before it looked like this:

before

After applying the patch, it should look like this (the tooltips should still work):

after

@wilsonge
Copy link
Contributor

I think this is a bad idea. Tooltips are pretty inaccessible and I know the accessibility group is working to remove many of the tooltips currently used in the CMS. So I think this PR is taking things in the wrong direction

@n9iels
Copy link
Contributor

n9iels commented Mar 29, 2015

It looks good, but I agree with @wilsonge. If the tooltip is not shown, it is not clear what kind of functions the icons have.

@peterlose
Copy link
Contributor

When I did #6264 I had the same idea of removing the text from the buttons. But decided that it would be bad for accessibility

@wilsonge
Copy link
Contributor

wilsonge commented Apr 1, 2015

On the basis of the above comments I'm going to close this PR

@wilsonge wilsonge closed this Apr 1, 2015
@smehrbrodt
Copy link
Contributor Author

Why? I don't understand the problem with accessiblity. If there is a problem, we should use the aria-label attribute, not just show a label everywhere

@rdeutz
Copy link
Contributor

rdeutz commented Apr 1, 2015

@smehrbrodt if you have a problem with coordination and you can't control the mouse pointer exactly over the button then you are not able to get the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants