New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] - Status code 301 for Force SSL option #6646

Merged
merged 1 commit into from Apr 4, 2015

Conversation

Projects
None yet
6 participants
@Kubik-Rubik
Member

Kubik-Rubik commented Apr 3, 2015

Changed status code for SSL redirects (Option: Force SSL in Global Configuration) to "301 Moved Permanently" as Google recommends it.

How to test

SSL has to be configured on your server to test this patch!

  • Activate the option "Force SSL" in the Global Configuration (for Site and Administrator).
  • Open the Developer Tools in your browser (usually button F12 in Windows)
  • Go to the frontpage and load the website manually with the scheme http:// (not https://) and check the status code on the tab "Network" in the developer tools.
  • Without the patch, you should see a 303 status code:
    2015-04-03 14_11_43-test
  • Apply patch with the help of the Patchtester component and check the status code again - 301
    2015-04-03 14_12_10-test
  • Do the same test for the backend!

See here for more details:

https://support.google.com/webmasters/answer/6073543
http://moz.com/blog/seo-tips-https-ssl
http://moz.com/learn/seo/redirection

Changed status code for SSL redirect (Option: Force SSL in Global Con…
…figuration) to "301 Moved Permanently" as Google recommends it.
@Simonkloostra

This comment has been minimized.

Show comment
Hide comment
@Simonkloostra

Simonkloostra Apr 4, 2015

I tested it succesfully. Note that this is actually the first time I actually tested code. I tried to test using https://docs.joomla.org/Testing_Joomla!_patches/, but the patch tester did not seem to load (stuck on: Preparing to fetch GitHub data). Therefor I loaded the repository from https://github.com/joomla/joomla-cms and replaced the 2 changed files.
Before the test the code was a 303, after applying it was a 301, so test was executed succesfully.

Simonkloostra commented Apr 4, 2015

I tested it succesfully. Note that this is actually the first time I actually tested code. I tried to test using https://docs.joomla.org/Testing_Joomla!_patches/, but the patch tester did not seem to load (stuck on: Preparing to fetch GitHub data). Therefor I loaded the repository from https://github.com/joomla/joomla-cms and replaced the 2 changed files.
Before the test the code was a 303, after applying it was a 301, so test was executed succesfully.

@dneukirchen

This comment has been minimized.

Show comment
Hide comment
@dneukirchen

dneukirchen Apr 4, 2015

Contributor

tested as described, test successful.
before patch 303, after patch 301.

Google is happy now... Thank you @Kubik-Rubik

Contributor

dneukirchen commented Apr 4, 2015

tested as described, test successful.
before patch 303, after patch 301.

Google is happy now... Thank you @Kubik-Rubik

@zero-24 zero-24 added the RTC label Apr 4, 2015

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Apr 4, 2015

Contributor

RTC 😄 Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6646.

Contributor

zero-24 commented Apr 4, 2015

RTC 😄 Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6646.

wilsonge added a commit that referenced this pull request Apr 4, 2015

Merge pull request #6646 from Kubik-Rubik/Improvement-Force-SSL-301-S…
…tatus-Code

[Improvement] - Status code 301 for Force SSL option

@wilsonge wilsonge merged commit 2686329 into joomla:staging Apr 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone Apr 4, 2015

@Kubik-Rubik Kubik-Rubik deleted the Kubik-Rubik:Improvement-Force-SSL-301-Status-Code branch Apr 4, 2015

@zero-24 zero-24 removed the RTC label Oct 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment