Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5939 | XMLReader::read returns false on invalid xml and error in ph... #6793

Closed
wants to merge 1 commit into from

Conversation

Achal-Aggarwal
Copy link
Contributor

@Achal-Aggarwal Achal-Aggarwal commented Apr 17, 2015

...p3. Throw an exception and stop loop execution if feed xml is bad.

…ror in php3. Throw an exception and stop loop execution if feed xml is bad.
@mbabker
Copy link
Contributor

mbabker commented May 8, 2016

Is this still valid against current staging? https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/feed/factory.php#L66-L80

Exceptions aren't thrown by XMLReader so the try/catch is definitely redundant code but the do/while loop has changed since this PR.

@brianteeman
Copy link
Contributor

Set status to Information Required.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6793.

@brianteeman
Copy link
Contributor

I am closing this at this time as it appears to have been resolved elsewhere and there has been no response to the comments. It can always b reopened if that is done.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6793.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants