Fixing JToolbarHelper::back()-Button #6844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it not be easier rather than adding a new icon just changing the icon (2nd param here https://github.com/joomla/joomla-cms/blob/staging/administrator/includes/toolbar.php#L153) to be icon-chevron-left? |
|
That means that all those, that use the back class would still be broken. It wouldn't really be B/C. |
|
|
|
I can confirm that this patch is working as described. I can see Back button icon after applying patch. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6844. |
|
RTC |
mbabker
added a commit
that referenced
this pull request
May 9, 2015
Fixing JToolbarHelper::back()-Button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JToolbarHelper::back() button currently does not display an icon, because it expects the class to be .icon-back, but it would have to be .icon-chevron-left. Theoretically, this could be solved with .icon-back:before:extend(.icon-chevron-left:before), but since our LESS compiler version in Joomla is ancient, we gotta basically hardcode this in here.
How to test? Add JToolbarHelper::back() somewhere in a view.html.php file in the backend. See that it has no icon. Apply the patch and see that it has an arrow.