New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing JToolbarHelper::back()-Button #6844

Merged
merged 2 commits into from May 9, 2015

Conversation

Projects
None yet
6 participants
@Hackwar
Member

Hackwar commented Apr 25, 2015

The JToolbarHelper::back() button currently does not display an icon, because it expects the class to be .icon-back, but it would have to be .icon-chevron-left. Theoretically, this could be solved with .icon-back:before:extend(.icon-chevron-left:before), but since our LESS compiler version in Joomla is ancient, we gotta basically hardcode this in here.

How to test? Add JToolbarHelper::back() somewhere in a view.html.php file in the backend. See that it has no icon. Apply the patch and see that it has an arrow.

Hackwar added some commits Apr 25, 2015

@wilsonge

This comment has been minimized.

Contributor

wilsonge commented Apr 28, 2015

Would it not be easier rather than adding a new icon just changing the icon (2nd param here https://github.com/joomla/joomla-cms/blob/staging/administrator/includes/toolbar.php#L153) to be icon-chevron-left?

@Hackwar

This comment has been minimized.

Member

Hackwar commented Apr 28, 2015

That means that all those, that use the back class would still be broken. It wouldn't really be B/C.

@OctavianC

This comment has been minimized.

Contributor

OctavianC commented May 5, 2015

result
Works!

@gunjanpatel

This comment has been minimized.

Contributor

gunjanpatel commented May 9, 2015

I can confirm that this patch is working as described. I can see Back button icon after applying patch.
Also the alternative solution(which doesn't need this patch) works too.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6844.

@zero-24

This comment has been minimized.

Contributor

zero-24 commented May 9, 2015

RTC

@zero-24 zero-24 added the RTC label May 9, 2015

mbabker added a commit that referenced this pull request May 9, 2015

Merge pull request #6844 from Hackwar/patch-57
Fixing JToolbarHelper::back()-Button

@mbabker mbabker merged commit cfbf129 into joomla:staging May 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zero-24 zero-24 added this to the Joomla! 3.4.2 milestone May 9, 2015

@zero-24 zero-24 removed the RTC label Oct 14, 2015

@Hackwar Hackwar deleted the Hackwar:patch-57 branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment