Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing JToolbarHelper::back()-Button #6844

merged 2 commits into from May 9, 2015


Copy link

@Hackwar Hackwar commented Apr 25, 2015

The JToolbarHelper::back() button currently does not display an icon, because it expects the class to be .icon-back, but it would have to be .icon-chevron-left. Theoretically, this could be solved with .icon-back:before:extend(.icon-chevron-left:before), but since our LESS compiler version in Joomla is ancient, we gotta basically hardcode this in here.

How to test? Add JToolbarHelper::back() somewhere in a view.html.php file in the backend. See that it has no icon. Apply the patch and see that it has an arrow.

Copy link

Would it not be easier rather than adding a new icon just changing the icon (2nd param here to be icon-chevron-left?

Copy link
Member Author

Hackwar commented Apr 28, 2015

That means that all those, that use the back class would still be broken. It wouldn't really be B/C.

Copy link


Copy link

I can confirm that this patch is working as described. I can see Back button icon after applying patch.
Also the alternative solution(which doesn't need this patch) works too.

This comment was created with the J!Tracker Application at

Copy link

zero-24 commented May 9, 2015


@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 9, 2015
mbabker added a commit that referenced this pull request May 9, 2015
Fixing JToolbarHelper::back()-Button
@mbabker mbabker merged commit cfbf129 into joomla:staging May 9, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.2 milestone May 9, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@Hackwar Hackwar deleted the patch-57 branch January 6, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

6 participants