Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FOF to 2.4.3 – The FINAL update #7081

Merged
merged 1 commit into from May 30, 2015

Conversation

Projects
None yet
4 participants
@nikosdion
Copy link
Contributor

commented May 30, 2015

This is the very last version of FOF 2.x to be released and included in Joomla! 3. No b/c breaks, no fixes except a tiny issue regarding redirection handling in the Download package.

Paging @wilsonge to merge it.

// Remove #__menu records for good measure! –– I think this is not necessary and causes the menu item to
// disappear on extension update.
/**
$query = $db->getQuery(true);

This comment has been minimized.

Copy link
@zero-24

zero-24 May 30, 2015

Contributor

@nikosdion do you expect this red lines?

This comment has been minimized.

Copy link
@nikosdion

nikosdion May 30, 2015

Author Contributor

Yeah. GitHub always does the same thing in the same place of the same file every single time I commit a FOF update.

This comment has been minimized.

Copy link
@wilsonge

wilsonge May 30, 2015

Contributor

We deleted them last time because of this - but it's just because github doesn't like comments

This comment has been minimized.

Copy link
@nikosdion

nikosdion May 30, 2015

Author Contributor

Still, it doesn't affect your ability to merge the code, right?

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented May 30, 2015

@nikosdion did you mean to delete the license file? If so I will merge, if not add it

@nikosdion

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2015

Yes, it doesn't make sense to duplicate the GPLv2 license document, considering that GPLv2 is Joomla!'s license as well.

wilsonge added a commit that referenced this pull request May 30, 2015

Merge pull request #7081 from nikosdion/feature/update-fof-2.4.3
Update FOF to 2.4.3 – The FINAL update

@wilsonge wilsonge merged commit a1d106a into joomla:staging May 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wilsonge wilsonge added this to the Joomla! 3.4.2 milestone May 30, 2015

@wilsonge

This comment has been minimized.

Copy link
Contributor

commented May 31, 2015

I should have said this when I merged it - but thankyou for all the hard work you've done on this Nic - it's really appreciated all the work you have gone through contributing this awesome resource to the project!

@nikosdion

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.