New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added switches to the admin module User Status (mod_status) #7174

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
@RickR2H
Contributor

RickR2H commented Jun 14, 2015

Changes:

  1. Added switches and make the link parameters work in the Administrator module "mod_status" so the links can be switched on and off.
  2. Updated the language file.
  3. The second switch is added as extra link to open a new Administrator window for easy Joomla management.

Test instruction:

  1. Go to the Module manager in the Administrator and set the top filter to Administrator
  2. Open the module "User Status"
  3. Turn on and off the "Show view site" and "Show view Administrator" switches and check if both links disappear and reappear in the bottom of the site (See screenshot).

Click the "Show Site" and the "Show Admin" links in the bottom of the Administrator area and check if they open a new Site window and an new Administrator Window. The links should also work when editing and article (See screenshot).

footer-links-site-admin-joomla

Added switches to the admin module mod_status
Added switches and make the parameters work
Updated the language file
Added an extra link to open a new Administrator window for easy Joomla
management

@RickR2H RickR2H changed the title from Added switches to the admin module mod_status to Added switches to the admin module User Status (mod_status) Jun 14, 2015

@roland-d

This comment has been minimized.

Show comment
Hide comment
@roland-d

roland-d Jun 14, 2015

Contributor

@RickR2H The issue is not in the PR but in Travis itself, I will see what I can do about it.

Contributor

roland-d commented Jun 14, 2015

@RickR2H The issue is not in the PR but in Travis itself, I will see what I can do about it.

@astridx

This comment has been minimized.

Show comment
Hide comment
@astridx

astridx Jun 15, 2015

Contributor
  1. I applied the patch and I saw the "Show Site" and the "Show Admin" links in the bottom of the Administrator area (snap1).
  2. I went to the Module manager in the Administrator and set the top filter to Administrator
  3. I opened the module "User Status" and saw the two new Buttons. They were activated.
  4. I turned off and on the "Show view site" and "Show view Administrator" switches and check if both links disappear and reappear in the bottom of the site after saving. (snap2 and snap3).
  5. I clicked the "Show Site" and the "Show Admin" links in the bottom of the Administrator area while they were activated. They open a new Site window/ a new Administrator Window.
  6. The links worked while editing and article, too.
    screen shot 2015-06-15 at 02 07 09screen shot 2015-06-15 at 02 07 12screen shot 2015-06-15 at 02 07 12
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7174.
Contributor

astridx commented Jun 15, 2015

  1. I applied the patch and I saw the "Show Site" and the "Show Admin" links in the bottom of the Administrator area (snap1).
  2. I went to the Module manager in the Administrator and set the top filter to Administrator
  3. I opened the module "User Status" and saw the two new Buttons. They were activated.
  4. I turned off and on the "Show view site" and "Show view Administrator" switches and check if both links disappear and reappear in the bottom of the site after saving. (snap2 and snap3).
  5. I clicked the "Show Site" and the "Show Admin" links in the bottom of the Administrator area while they were activated. They open a new Site window/ a new Administrator Window.
  6. The links worked while editing and article, too.
    screen shot 2015-06-15 at 02 07 09screen shot 2015-06-15 at 02 07 12screen shot 2015-06-15 at 02 07 12
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7174.
@RichardR2H

This comment has been minimized.

Show comment
Hide comment
@RichardR2H

RichardR2H Jun 15, 2015

@test Succesfully tested and works!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7174.

@test Succesfully tested and works!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7174.

@ghazal

This comment has been minimized.

Show comment
Hide comment
@ghazal

ghazal Jun 15, 2015

Contributor

@test
Nice new feature. Tks.
Works OK here.

Contributor

ghazal commented Jun 15, 2015

@test
Nice new feature. Tks.
Works OK here.

@Bakual

View changes

Show outdated Hide outdated administrator/language/en-GB/en-GB.mod_status.ini
@@ -7,6 +7,11 @@ MOD_STATUS="User Status"
MOD_STATUS_BACKEND_USERS_0="Admins"
MOD_STATUS_BACKEND_USERS_1="Admin"
MOD_STATUS_BACKEND_USERS_MORE="Admins"
MOD_STATUS_FIELD_SHOW_VIEWSITE_LABEL="Show View Site"
MOD_STATUS_FIELD_SHOW_VIEWSITE_DESC="Show a link to the website homepage."
MOD_STATUS_FIELD_LINK_VIEWSITE_LABEL="Show Admin"

This comment has been minimized.

@Bakual

Bakual Jun 15, 2015

Contributor

Shouldn't that key be named something like MOD_STATUS_FIELD_LINK_VIEWADMIN_LABEL as it opens a new admin window, not site?

@Bakual

Bakual Jun 15, 2015

Contributor

Shouldn't that key be named something like MOD_STATUS_FIELD_LINK_VIEWADMIN_LABEL as it opens a new admin window, not site?

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 15, 2015

Contributor

I can see a small use of a parameter for the "View Site" link. Especially since the code already checks for that (not existing) parameter.

I don't really see the use for a link to open a new admin window. The exact same can be achieved by simply ctrl-clicking the Joomla icon in the top left corner. At least on Windows. On other OS it's likely similar simple.

Contributor

Bakual commented Jun 15, 2015

I can see a small use of a parameter for the "View Site" link. Especially since the code already checks for that (not existing) parameter.

I don't really see the use for a link to open a new admin window. The exact same can be achieved by simply ctrl-clicking the Joomla icon in the top left corner. At least on Windows. On other OS it's likely similar simple.

@RickR2H

This comment has been minimized.

Show comment
Hide comment
@RickR2H

RickR2H Jun 15, 2015

Contributor

@Bakual Regarding the language string you've got a point! I'll change it accordingly.

Contributor

RickR2H commented Jun 15, 2015

@Bakual Regarding the language string you've got a point! I'll change it accordingly.

@zero-24 zero-24 added the New Feature label Jun 15, 2015

@RickR2H

This comment has been minimized.

Show comment
Hide comment
@RickR2H

RickR2H Jun 15, 2015

Contributor

@Bakual The top left click doesn't work when an article is opened!

As a regular web editor I'm coping a lot of article text/code back and forth. When I've opened an article, I have to copy the admin URL and paste it in a new window to open an other article or module. I thought this extra link would make this process a little easier.

Contributor

RickR2H commented Jun 15, 2015

@Bakual The top left click doesn't work when an article is opened!

As a regular web editor I'm coping a lot of article text/code back and forth. When I've opened an article, I have to copy the admin URL and paste it in a new window to open an other article or module. I thought this extra link would make this process a little easier.

Changed language string
Changed to make ik more conform
@MSnoeren1995

This comment has been minimized.

Show comment
Hide comment
@MSnoeren1995

MSnoeren1995 Jun 15, 2015

@test Works! Nice new feature!

@test Works! Nice new feature!

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 15, 2015

Contributor

The top left click doesn't work when an article is opened!

I'll give you that. Thus usecase is found. 😄

Contributor

Bakual commented Jun 15, 2015

The top left click doesn't work when an article is opened!

I'll give you that. Thus usecase is found. 😄

@Bakual Bakual added the RTC label Jun 15, 2015

@Bakual Bakual added this to the Joomla! 3.5.0 milestone Jun 15, 2015

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 15, 2015

Contributor

Setting RTC based on various tests.
Since we are currently in language freeze for 3.4.2, this has to wait or go into 3.5.0. Which may be the same anyway 😄

Contributor

Bakual commented Jun 15, 2015

Setting RTC based on various tests.
Since we are currently in language freeze for 3.4.2, this has to wait or go into 3.5.0. Which may be the same anyway 😄

@RickR2H

This comment has been minimized.

Show comment
Hide comment
@RickR2H

RickR2H Jun 15, 2015

Contributor

Nice 😄 My first real contribution will be a fact!

Contributor

RickR2H commented Jun 15, 2015

Nice 😄 My first real contribution will be a fact!

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 15, 2015

Contributor

Merged into 3.5-dev with 53e6aa9.

Thanks @RickR2H and grats for your first PR 👍
It will be part of Joomla 3.5 and your named will be mentioned in the release announcement 😄

Contributor

Bakual commented Jun 15, 2015

Merged into 3.5-dev with 53e6aa9.

Thanks @RickR2H and grats for your first PR 👍
It will be part of Joomla 3.5 and your named will be mentioned in the release announcement 😄

@Bakual Bakual closed this Jun 15, 2015

@peterlose

This comment has been minimized.

Show comment
Hide comment
@peterlose

peterlose Jun 15, 2015

Contributor

Sorry for commenting on a merged PR. But why add a link to the admin panel? mod_status is an admin module.

Contributor

peterlose commented Jun 15, 2015

Sorry for commenting on a merged PR. But why add a link to the admin panel? mod_status is an admin module.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 15, 2015

Contributor

@losedk Rick explained a few posts above.

Contributor

Bakual commented Jun 15, 2015

@losedk Rick explained a few posts above.

@peterlose

This comment has been minimized.

Show comment
Hide comment
@peterlose

peterlose Jun 15, 2015

Contributor

@Bakual Ahh I see, valid argument. But it seems a bit excessive to add yet another link in the footer.

Contributor

peterlose commented Jun 15, 2015

@Bakual Ahh I see, valid argument. But it seems a bit excessive to add yet another link in the footer.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jun 15, 2015

Contributor

Sorry but this is the wrong place for this change AND/OR the module needs
to be renamed and be given a new description

User Status
Administrator

This module shows the status of the logged-in users.

On 15 June 2015 at 14:06, Peter Lose notifications@github.com wrote:

@Bakual https://github.com/Bakual Ahh I see, valid argument. But it
seems a bit excessive to add yet another link in the footer.


Reply to this email directly or view it on GitHub
#7174 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Contributor

brianteeman commented Jun 15, 2015

Sorry but this is the wrong place for this change AND/OR the module needs
to be renamed and be given a new description

User Status
Administrator

This module shows the status of the logged-in users.

On 15 June 2015 at 14:06, Peter Lose notifications@github.com wrote:

@Bakual https://github.com/Bakual Ahh I see, valid argument. But it
seems a bit excessive to add yet another link in the footer.


Reply to this email directly or view it on GitHub
#7174 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 15, 2015

Contributor

@losedk If it's an issue, we could disable it by default. So nothing changes for anyone. But I guess most probably don't notice at all.

Contributor

Bakual commented Jun 15, 2015

@losedk If it's an issue, we could disable it by default. So nothing changes for anyone. But I guess most probably don't notice at all.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Jun 15, 2015

Contributor

This module shows the status of the logged-in users.

It also showed the link to frontend before this change. So it was already not only about users.
Maybe it's a bit misnamed indeed. The module itself uses mod_status as its code-name.

Contributor

Bakual commented Jun 15, 2015

This module shows the status of the logged-in users.

It also showed the link to frontend before this change. So it was already not only about users.
Maybe it's a bit misnamed indeed. The module itself uses mod_status as its code-name.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jun 15, 2015

Contributor

I know its only a small change but we've been trying to remove stuff from
the core and to make the UI cleaner and simpler.

If we accept every PR because someone has a usecase for it then we will
have the JED inside the core.

In this case it can be achieved either by installing a module or by a
template override.

On 15 June 2015 at 14:19, Thomas Hunziker notifications@github.com wrote:

This module shows the status of the logged-in users.

It also showed the link to frontend before this change. So it was already
not only about users.
Maybe it's a bit misnamed indeed. The module itself uses mod_status as
its code-name.


Reply to this email directly or view it on GitHub
#7174 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Contributor

brianteeman commented Jun 15, 2015

I know its only a small change but we've been trying to remove stuff from
the core and to make the UI cleaner and simpler.

If we accept every PR because someone has a usecase for it then we will
have the JED inside the core.

In this case it can be achieved either by installing a module or by a
template override.

On 15 June 2015 at 14:19, Thomas Hunziker notifications@github.com wrote:

This module shows the status of the logged-in users.

It also showed the link to frontend before this change. So it was already
not only about users.
Maybe it's a bit misnamed indeed. The module itself uses mod_status as
its code-name.


Reply to this email directly or view it on GitHub
#7174 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@RickR2H

This comment has been minimized.

Show comment
Hide comment
@RickR2H

RickR2H Jun 15, 2015

Contributor

I agree that every change has to be carefully considered. The reason why I made the modifications was that it could open a new site window but not a new admin window which seems strange to me. Don't forget the logout link which is also present on the bottom.
In the menu bar the three options, "open a new admin window", "open a new site window" and "logout" are all possible in the standard non-editor interface. The whole top menu is disabled when editing a article/module so we can't access these items. In my humble opinion adding the link to the module and make these three items work in the footer seems a logical step. In the process also added the missing option switches to the module.

Switching all the links off in the footer by default could be a good option for the people who need a cleaner interface.

Contributor

RickR2H commented Jun 15, 2015

I agree that every change has to be carefully considered. The reason why I made the modifications was that it could open a new site window but not a new admin window which seems strange to me. Don't forget the logout link which is also present on the bottom.
In the menu bar the three options, "open a new admin window", "open a new site window" and "logout" are all possible in the standard non-editor interface. The whole top menu is disabled when editing a article/module so we can't access these items. In my humble opinion adding the link to the module and make these three items work in the footer seems a logical step. In the process also added the missing option switches to the module.

Switching all the links off in the footer by default could be a good option for the people who need a cleaner interface.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Jun 15, 2015

Contributor

On 15 Jun 2015 3:18 pm, "Rick Spaan" notifications@github.com wrote:

Switching all the links off in the footer by default could be a good
option for the people who need a cleaner interface.

As is creating a new module available on the JED for those that want the
extra links


Reply to this email directly or view it on GitHub.

Contributor

brianteeman commented Jun 15, 2015

On 15 Jun 2015 3:18 pm, "Rick Spaan" notifications@github.com wrote:

Switching all the links off in the footer by default could be a good
option for the people who need a cleaner interface.

As is creating a new module available on the JED for those that want the
extra links


Reply to this email directly or view it on GitHub.

@RickR2H

This comment has been minimized.

Show comment
Hide comment
@RickR2H

RickR2H Jun 15, 2015

Contributor

Net time a I carefully consider creating a PR...

Contributor

RickR2H commented Jun 15, 2015

Net time a I carefully consider creating a PR...

@mbabker

This comment has been minimized.

Show comment
Hide comment
@mbabker

mbabker Jun 15, 2015

Member

Nobody's trying to suggest that you shouldn't contribute. The reality is for a long time we've accepted a lot of pulls simply because someone took the time to code it and we didn't want to say no. We really need to get to a point where things are being looked at beyond "does it work", which is probably 95% of what influences whether something is determined to be "ready to commit".

Member

mbabker commented Jun 15, 2015

Nobody's trying to suggest that you shouldn't contribute. The reality is for a long time we've accepted a lot of pulls simply because someone took the time to code it and we didn't want to say no. We really need to get to a point where things are being looked at beyond "does it work", which is probably 95% of what influences whether something is determined to be "ready to commit".

@peterlose

This comment has been minimized.

Show comment
Hide comment
@peterlose

peterlose Jun 15, 2015

Contributor

Sorry for starting this debate @RickR2H. My intent was not to bash your PR and contribution, it is very appreciated :) I'm merely focused on keeping the UI as clean as possible and I was just a bit puzzled by this being merged so quickly.

Contributor

peterlose commented Jun 15, 2015

Sorry for starting this debate @RickR2H. My intent was not to bash your PR and contribution, it is very appreciated :) I'm merely focused on keeping the UI as clean as possible and I was just a bit puzzled by this being merged so quickly.

@RickR2H

This comment has been minimized.

Show comment
Hide comment
@RickR2H

RickR2H Jun 15, 2015

Contributor

@losedk I don't take it personally and I think it is good to have a debate and be critical about whether a change needs to be in the core or not. As a newbie contributor like me it is difficult to decide whether a change is needed or not as there are no direct guidelines. Also with a lot of (cosmetic)changes usability plays an important role but also personal taste. At the end I hope these discussions will make Joomla a better product...!

Contributor

RickR2H commented Jun 15, 2015

@losedk I don't take it personally and I think it is good to have a debate and be critical about whether a change needs to be in the core or not. As a newbie contributor like me it is difficult to decide whether a change is needed or not as there are no direct guidelines. Also with a lot of (cosmetic)changes usability plays an important role but also personal taste. At the end I hope these discussions will make Joomla a better product...!

@peterlose

This comment has been minimized.

Show comment
Hide comment
@peterlose

peterlose Jun 15, 2015

Contributor

@RickR2H Great! Hope you will continue to contribute to Joomla and make it even better :)

Contributor

peterlose commented Jun 15, 2015

@RickR2H Great! Hope you will continue to contribute to Joomla and make it even better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment