Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS fix #7254

Closed
wants to merge 3 commits into from
Closed

PHPCS fix #7254

wants to merge 3 commits into from

Conversation

shur
Copy link
Contributor

@shur shur commented Jun 23, 2015

.

@wilsonge
Copy link
Contributor

Hi,
Could you please remove the fix at the FOF library. That's a 3rd party maintained library (https://github.com/akeeba/fof/tree/fof-2.x) so you need to do the pull request to there and then when Nic releases and update we'll merge it into the CMS!

Once you removed that part I'll merge the other part of this PR
Thanks :)

@shur
Copy link
Contributor Author

shur commented Jun 23, 2015

Yes indeed, I removed the changes.

Merged:
akeeba/fof#506

@wilsonge wilsonge added the RTC This Pull Request is Ready To Commit label Jun 23, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.3 milestone Jun 23, 2015
@wilsonge
Copy link
Contributor

Awesome. RTC

@zero-24 zero-24 modified the milestones: Joomla! 3.4.3, Joomla! 3.4.4 Jul 2, 2015
@Kubik-Rubik
Copy link
Member

Thank you @shur! Merged.

@shur shur deleted the patch-5 branch July 3, 2015 15:28
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla! 3.4.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shur @wilsonge @Kubik-Rubik @zero-24 @joomla-cms-bot