Example revision of the JHtmlTabs using JHtmlElement #7967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. I'll have to wait for TCI results before I can fix all the styling issues.
@Fedik Thanks for the input. These two methods will make this class even more user friendly.
| if (!array_key_exists((string) $group, $loaded)) | ||
| { | ||
| // Include MooTools framework | ||
| JHtml::_('behavior.framework', true); |
There was a problem hiding this comment.
Is there a reason to include Mootools?
There was a problem hiding this comment.
I didn't change the JavaScript portion, just the rendering of the actual HTML
|
@Mathewlenning I think you based this on the old html/tabs.php which is not the bootstrap version, thus the dd, dl elements and also the Mootools library dependency and the extra tabs.js script. The bootstrap version should be located inside the html/bootstrap.php file |
|
O.k. Thanks @dgt41 I'm glad to know that JHtmlTabs isn't actually being used! I'll make a different example after I've looked at the bootstrap file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of how pull request #7948 can simplify our lives.
This is less than ideal. I'd actually prefer to just send the wrapper and let the developer add the tab panes using the JHtmlElement interface.
But even in its current form it is way better than the current JHtmlTabs implementation.
BTW does anyone know why we are adding the empty dt/dd set? or can I remove it?