CLEANING-JComponentRouterBase #7985

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
@Mathewlenning
Contributor

Mathewlenning commented Sep 30, 2015

Removed a few redundant else clauses

libraries/cms/component/router/base.php
- else
+ $this->app = $app;
+
+ if (!is_null($menu))

This comment has been minimized.

@wilsonge

wilsonge Oct 2, 2015

Contributor

I don't think you want the ! here

@wilsonge

wilsonge Oct 2, 2015

Contributor

I don't think you want the ! here

This comment has been minimized.

@Mathewlenning

Mathewlenning Oct 2, 2015

Contributor

I most certainly do not! Nice catch I'll fix it tonight when I get back to my desk.

Thanks

Sincerely,
Mathew Lenning

P.S. This message was sent via iPhone, so please forgive any errors

On Oct 2, 2015, at 5:03 PM, George Wilson notifications@github.com wrote:

In libraries/cms/component/router/base.php:

    }
  •   if ($menu)
    
  •   {
    
  •       $this->menu = $menu;
    
  •   }
    
  •   else
    
  •   $this->app = $app;
    
  •   if (!is_null($menu))
    
    I don't think you want the ! here


Reply to this email directly or view it on GitHub.

@Mathewlenning

Mathewlenning Oct 2, 2015

Contributor

I most certainly do not! Nice catch I'll fix it tonight when I get back to my desk.

Thanks

Sincerely,
Mathew Lenning

P.S. This message was sent via iPhone, so please forgive any errors

On Oct 2, 2015, at 5:03 PM, George Wilson notifications@github.com wrote:

In libraries/cms/component/router/base.php:

    }
  •   if ($menu)
    
  •   {
    
  •       $this->menu = $menu;
    
  •   }
    
  •   else
    
  •   $this->app = $app;
    
  •   if (!is_null($menu))
    
    I don't think you want the ! here


Reply to this email directly or view it on GitHub.

@Kubik-Rubik

This comment has been minimized.

Show comment
Hide comment
@Kubik-Rubik

Kubik-Rubik May 8, 2016

Member

Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. I will close this PR now. If you want to update your PR, then this can be re-opened.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7985.

Member

Kubik-Rubik commented May 8, 2016

Thank you for creating this. It’s been some time since you created this and there are now some merge conflicts that prevent a direct merge. I will close this PR now. If you want to update your PR, then this can be re-opened.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7985.

@Kubik-Rubik Kubik-Rubik closed this May 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment