Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Follow up on #8085 - refactor com_contact form to support renderField #8473
While there are a couple of code style changes in files that are not directly related to com_contact, I thought it would be good to include them in this PR since they were edited in the same context.
The method used to check for a required state and / or field of the type label is not very clean but should suffice for now. I normally would have created or rewritten the fields and their layouts but that would have been too much for this PR and, as @wilsonge told me, that is planned for the near future. Take a look at layouts/joomla/form/field/radio.php to see where this is going.
My goal was to unify the output / markup, to fix some bugs and add some functionality to all of the forms of com_contact and com_users (registration / login).
Long story short, how to test?
If you have any questions, suggestions or corrections feel free to contact me.
I have tested this item
Otherwise the PR looks very good. Awesome work!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8473.
Thank you for your comments and tests.
I replaced the StringHelper::strlen method with the nativ strlen function and extended the foreach loop to only render the fieldset when captcha was enabled.
It would mean a lot to me if you could test it again, please.
@brianteeman thank you for your input.
I would like to see the addition of the well class suffix to the form more of a bug fix than a potential b/c issue. If we look at the registration and login view of com_users e.g, both forms have the well suffix. Adding it would add to the general user experience (forms look like "this" ~> POLS).
I've checked approx. 50 sites (google / j.org showcase) where this would have no negative impact.
Templates aren't covered by our B/C policy. So this PR doesn't have to be backward compatible in this regard.