-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds language flags to listing tables #8815
Adds language flags to listing tables #8815
Conversation
This works fine. Diff available here: |
1. Convert default image falgs to button like the stars 2. Add tooltip with language description Changed in templates and menu items views
@infograf768 i made some changes.
Tested and it works, but still want to do some review to the jgrid code. Another way, that will be more near to waht you proposed is to put also put the language native name inside the button. What do you think? |
The button is a nice idea. |
@infograf768 i will make a new PR for the default language buttons in templates and menus. This one will stay just for the language flags in the language columns. I improved a bit the code and added them to hathor too. For com_weblinks i created a PR joomla-extensions/weblinks#176 and a change to hathor weblinks override (b40b35e) here. |
@infograf768 the language buttons are in this PR: #8826 |
I have tested this item ✅ successfully on b40b35e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
Thanks.
|
@andrepereiradasilva you have to resync this as there is a msg: |
This PR has received new commits. CC: @infograf768 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
This PR has received new commits. CC: @infograf768 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
No conflicts now. |
I have tested this item ✅ successfully on 84e643a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
Good spot @infograf768 |
yes, but in the menu items list it looks like using 15% is much better because Home is set to 5% |
This PR has received new commits. CC: @brianteeman, @infograf768 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
@infograf768, @brianteeman 15% now. |
I have tested this item ✅ successfully on 850a8e5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
1 similar comment
I have tested this item ✅ successfully on 850a8e5 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815. |
Description
This PR adds language flags to listing tables in menu items, categories, articles, featured articles, modules, banners, news feeds, tags and contacts (and their modals) in administrator panel.
Example:
How to test
For com_weblinks check joomla-extensions/weblinks#176
Observations
Suggestions are welcome.