New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement countItems for extensions with sections #9580

Merged
merged 4 commits into from Mar 29, 2016

Conversation

Projects
None yet
7 participants
@bembelimen
Contributor

bembelimen commented Mar 25, 2016

Pull Request for Issue #9186

With 3.5 a new function was implemented in Joomla!: the items of a category can be counted via a helper method. The problem is, that this only works for basic category calls without sections because the extension string is not handled properly!

Summary of Changes

I moved the countItems stuff to its own method in the category and implemented a cleaner way for this function.

Testing Instructions

  1. Open the contact categories
  2. Change the link paameter to extension=com_contact.foobar
  3. create a new category
  4. no Counting visible, because Joomla! tries to load Contact.FoobarHelper class (pay attention to the ".")
  5. Apply path => Try again

Now extensions could use the second parameter "$section" to check for the correct items

@matrikular

This comment has been minimized.

Show comment
Hide comment
@matrikular

matrikular Mar 25, 2016

Contributor

I have tested this item successfully on 6ed19dd


Since without a component that supports sections one cannot really check if the count is still correct. I've tested this by assinging test contacts to that created category via phpmyadmin.

contact_category
contacts

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.

Contributor

matrikular commented Mar 25, 2016

I have tested this item successfully on 6ed19dd


Since without a component that supports sections one cannot really check if the count is still correct. I've tested this by assinging test contacts to that created category via phpmyadmin.

contact_category
contacts

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.

@chmst

This comment has been minimized.

Show comment
Hide comment
@chmst

chmst Mar 25, 2016

Contributor

I tested this successfully - simulating sections via phpmyadmin as matrikular did.

Contributor

chmst commented Mar 25, 2016

I tested this successfully - simulating sections via phpmyadmin as matrikular did.

@chmst

This comment has been minimized.

Show comment
Hide comment
@chmst

chmst Mar 25, 2016

Contributor

I have tested this item successfully on 6ed19dd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.

Contributor

chmst commented Mar 25, 2016

I have tested this item successfully on 6ed19dd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Mar 26, 2016

Contributor

@brianteeman can we get a RTC label here?

Contributor

zero-24 commented Mar 26, 2016

@brianteeman can we get a RTC label here?

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Mar 26, 2016

Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.

Contributor

brianteeman commented Mar 26, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9580.

@joomla-cms-bot joomla-cms-bot added the RTC label Mar 26, 2016

@Kubik-Rubik Kubik-Rubik modified the milestones: Joomla 3.5.2, Joomla 3.5.1 Mar 29, 2016

@Kubik-Rubik

This comment has been minimized.

Show comment
Hide comment
@Kubik-Rubik

Kubik-Rubik Mar 29, 2016

Member

Thank you @bembelimen! This can be merged already for the next 3.5.1.

Member

Kubik-Rubik commented Mar 29, 2016

Thank you @bembelimen! This can be merged already for the next 3.5.1.

@Kubik-Rubik Kubik-Rubik merged commit eeba92e into joomla:staging Mar 29, 2016

2 checks passed

JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@joomla-cms-bot joomla-cms-bot removed the RTC label Mar 29, 2016

@Kubik-Rubik

This comment has been minimized.

Show comment
Hide comment
@Kubik-Rubik

Kubik-Rubik Mar 29, 2016

Member

Sorry, I had to revert the merge because we are already in RC state and I should not have merged it.

@bembelimen Could you please do the same PR once again, then we can merge it into 3.5.2. Sorry for the inconvenience!

Member

Kubik-Rubik commented Mar 29, 2016

Sorry, I had to revert the merge because we are already in RC state and I should not have merged it.

@bembelimen Could you please do the same PR once again, then we can merge it into 3.5.2. Sorry for the inconvenience!

wilsonge added a commit that referenced this pull request Mar 29, 2016

@Kubik-Rubik

This comment has been minimized.

Show comment
Hide comment
@Kubik-Rubik

Kubik-Rubik Mar 29, 2016

Member

@wilsonge Thank you for merging! :-)

Member

Kubik-Rubik commented Mar 29, 2016

@wilsonge Thank you for merging! :-)

@bembelimen bembelimen deleted the bembelimen:patch-15 branch Mar 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment