New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image contact category list new #9906

Merged
merged 8 commits into from May 2, 2016

Conversation

Projects
None yet
9 participants
@drmenzelit
Contributor

drmenzelit commented Apr 14, 2016

Pull Request replacing #8580

Summary of Changes

That is a clean pull request replacing #8580 since I accidentally removed the installation folder on my last commit. Sorry for the inconvenience!
Removed the image column parameters as asked by @wilsonge

Testing Instructions

Same as #8580 but without parameters.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 14, 2016

I have tested this item successfully on 9947a91

Test on Protostar.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

franz-wohlkoenig commented Apr 14, 2016

I have tested this item successfully on 9947a91

Test on Protostar.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.
@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 14, 2016

Contributor

I think this will need a change in the beez3 template as that template has an override for this view


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

Contributor

brianteeman commented Apr 14, 2016

I think this will need a change in the beez3 template as that template has an override for this view


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Apr 14, 2016

I have tested this item 🔴 unsuccessfully on 9947a91

Works on Protostar, not on Beez3, so i have to change the Test-Result.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

franz-wohlkoenig commented Apr 14, 2016

I have tested this item 🔴 unsuccessfully on 9947a91

Works on Protostar, not on Beez3, so i have to change the Test-Result.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@joomla-cms-bot

This comment has been minimized.

Show comment
Hide comment
@joomla-cms-bot

joomla-cms-bot Apr 14, 2016

This PR has received new commits.

CC: @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

joomla-cms-bot commented Apr 14, 2016

This PR has received new commits.

CC: @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@wojsmol

This comment has been minimized.

Show comment
Hide comment
@wojsmol
Contributor

wojsmol commented Apr 14, 2016

@joomla-cms-bot

This comment has been minimized.

Show comment
Hide comment
@joomla-cms-bot

joomla-cms-bot Apr 14, 2016

This PR has received new commits.

CC: @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

joomla-cms-bot commented Apr 14, 2016

This PR has received new commits.

CC: @franz-wohlkoenig


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@rdeutz rdeutz added this to the Joomla! 3.6.0 milestone Apr 15, 2016

@iljabos

This comment has been minimized.

Show comment
Hide comment
@iljabos

iljabos Apr 15, 2016

I have tested this item 🔴 unsuccessfully on bfa98d8

I have tested this but there was no image in the contactlist.
Contact webmaster does have an image.
I tried it on Beez3 and Protostar.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

iljabos commented Apr 15, 2016

I have tested this item 🔴 unsuccessfully on bfa98d8

I have tested this but there was no image in the contactlist.
Contact webmaster does have an image.
I tried it on Beez3 and Protostar.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@drmenzelit

This comment has been minimized.

Show comment
Hide comment
@drmenzelit

drmenzelit Apr 15, 2016

Contributor

@iljabos Can you please explain what you did?

Contributor

drmenzelit commented Apr 15, 2016

@iljabos Can you please explain what you did?

@mikeveeckmans

This comment has been minimized.

Show comment
Hide comment
@mikeveeckmans

mikeveeckmans Apr 15, 2016

I have tested this item successfully on bfa98d8

Works fine here


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

mikeveeckmans commented Apr 15, 2016

I have tested this item successfully on bfa98d8

Works fine here


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@iljabos

This comment has been minimized.

Show comment
Hide comment
@iljabos

iljabos Apr 15, 2016

I have tested this item successfully on bfa98d8

Second time I tested succesfull for a list of contacts in a single category. The first time I used featured contacts.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

iljabos commented Apr 15, 2016

I have tested this item successfully on bfa98d8

Second time I tested succesfull for a list of contacts in a single category. The first time I used featured contacts.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@brianteeman

This comment has been minimized.

Show comment
Hide comment
@brianteeman

brianteeman Apr 15, 2016

Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

Contributor

brianteeman commented Apr 15, 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 15, 2016

@MDXBilal12

This comment has been minimized.

Show comment
Hide comment
@MDXBilal12

MDXBilal12 Apr 19, 2016

I have tested this item successfully on bfa98d8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

MDXBilal12 commented Apr 19, 2016

I have tested this item successfully on bfa98d8


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9906.

@rdeutz rdeutz added the New Feature label May 2, 2016

@rdeutz rdeutz merged commit 9b75278 into joomla:staging May 2, 2016

2 checks passed

JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brianteeman brianteeman removed the RTC label May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment