This repository has been archived by the owner. It is now read-only.

JBrowser issue #1008

Closed
Denitz opened this Issue Mar 20, 2012 · 4 comments

Comments

Projects
None yet
6 participants
Contributor

Denitz commented Mar 20, 2012

Found notices in error.log of Joomla 2.5.3:
PHP Notice: Undefined offset: 1 in /libraries/joomla/environment/browser.php on line 562

Current Joomla code for 562 is:

list ($this->_majorVersion, $this->_minorVersion) = explode('.', $version[1]);
Contributor

aaronschmitz commented Mar 25, 2012

This appears to be resolved in the latest version of the platform. The original code was:
preg_match('|Version/ |', $this->_agent, $version);
list ($this->_majorVersion, $this->_minorVersion) = explode('.', $version[1]);

Code is now:
if (preg_match('|Version/ |', $this->_agent, $version))
{
list ($this->_majorVersion, $this->_minorVersion) = explode('.', $version[1]);
return;
}

I don't think this is solved.. I'm runing the lates version and still getting the notices on iPad and iPhones...

Can confirm this patch was never added since the 2.5.1 , browser.php line 562 is same in 2.51 and 2.5.6 . However the patch from aaronschmitz does work

Contributor

elinw commented Nov 23, 2012

@youjoomla you could propose that as a patch on the 2.5.x tracker.

In the meantime as a platform issue this should be closed.

@dongilbert dongilbert closed this Mar 19, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.