This repository has been archived by the owner. It is now read-only.

Fix for issue 183 - allow additional characters in JFolder #1067

Merged
merged 2 commits into from Oct 9, 2012

Conversation

Projects
None yet
4 participants
@aaronschmitz
Contributor

aaronschmitz commented Mar 29, 2012

Allowed characters based on http://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words

Additional characters allowed in JFolder names: ()[]{}#$^+.'~`!@&=;,
Disallow : in JFolder names

@chdemko

This comment has been minimized.

Show comment
Hide comment
@chdemko

chdemko Mar 29, 2012

Contributor

see #1007

Contributor

chdemko commented Mar 29, 2012

see #1007

@aaronschmitz

This comment has been minimized.

Show comment
Hide comment
@aaronschmitz

aaronschmitz Mar 29, 2012

Contributor

Are we depreciating the current file system?

Contributor

aaronschmitz commented Mar 29, 2012

Are we depreciating the current file system?

@elinw

This comment has been minimized.

Show comment
Hide comment
@elinw

elinw Mar 29, 2012

Contributor

Christophe I don't understand the reference. Yes you have a pull request but from what i can tell first, you have not addressed this issue anywhere in your pull request (in fact JFolder and makeSafe both seem to have disappeared). If you are asking Aaron to make a similar pull request against your repo that's fine but you need to explain that not expect people to figure that out. There's no problem with people touching the same files as long as everyone is using git correctly.

In the mean time this is a highly useful and important bug fix ( : for sure should not be in the regex).

Contributor

elinw commented Mar 29, 2012

Christophe I don't understand the reference. Yes you have a pull request but from what i can tell first, you have not addressed this issue anywhere in your pull request (in fact JFolder and makeSafe both seem to have disappeared). If you are asking Aaron to make a similar pull request against your repo that's fine but you need to explain that not expect people to figure that out. There's no problem with people touching the same files as long as everyone is using git correctly.

In the mean time this is a highly useful and important bug fix ( : for sure should not be in the regex).

@chdemko

This comment has been minimized.

Show comment
Hide comment
@chdemko

chdemko Mar 29, 2012

Contributor

it's just a reference to the new file system because the old one will be deprecated

Contributor

chdemko commented Mar 29, 2012

it's just a reference to the new file system because the old one will be deprecated

@elinw

This comment has been minimized.

Show comment
Hide comment
@elinw

elinw Mar 29, 2012

Contributor

So most of us can't read minds, it's important to explain what you mean when you paste a link.
I'm not sure what the fact that it will be deprecated has to do with the bug fix though.

Contributor

elinw commented Mar 29, 2012

So most of us can't read minds, it's important to explain what you mean when you paste a link.
I'm not sure what the fact that it will be deprecated has to do with the bug fix though.

@aaronschmitz

This comment has been minimized.

Show comment
Hide comment
@aaronschmitz

aaronschmitz Aug 22, 2012

Contributor

As far as I can tell #1007 isn't going to be ready for a while. Do we want to get this fixed before we tag 12.2?

Contributor

aaronschmitz commented Aug 22, 2012

As far as I can tell #1007 isn't going to be ready for a while. Do we want to get this fixed before we tag 12.2?

@LouisLandry

This comment has been minimized.

Show comment
Hide comment
@LouisLandry

LouisLandry Oct 9, 2012

Contributor

Thanks Aaron!

Contributor

LouisLandry commented Oct 9, 2012

Thanks Aaron!

LouisLandry added a commit that referenced this pull request Oct 9, 2012

Merge pull request #1067 from aaronschmitz/foldernames
Fix for issue 183 - allow additional characters in JFolder

@LouisLandry LouisLandry merged commit 3727079 into joomla:staging Oct 9, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.