This repository has been archived by the owner. It is now read-only.

images scaled by Edge #1130

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

romacron commented Apr 6, 2012

In Order to force image scaling to an specific Edge we had decided to set for an width or an height an (int)0.
In example you want to transform an image to width=200px you must set the height (the opposite Value) to 0
so you are able to resize an imageStack with same matching Edges.

romacron added some commits Jan 5, 2012

i think there must be an imagedestroy inside the class
othwise it can combines with an __destruct() function
Merge pull request #1 from romacron/patch-1
i think there must be an imagedestroy inside the class
the db instancer called to late for sterr
so replaced the JFactory::getDBO() up on the method var creators
By using more then one Colorpicker in a form the trigger must identif…
…y by an DOM id to get the colorpicker Targets.

If someone check against/commit, please don't forget to update the compressed Version
Contributor

elinw commented Apr 6, 2012

See #1095, for discussion of how to handle the issue in 3c28b42.

Contributor

realityking commented Apr 6, 2012

I think you have some problem with github. This pull request has changes that have nothing to do with the description and isn't mergeable.

Contributor

romacron commented Apr 8, 2012

Hello Elin, i have seen your comment. In order that will get the git running for me, i will check the #1095 with the info from andre.

Perhaps someone can tell me how i remove the
d1672be i think there must be an imagedestroy inside the class
188aa37 Merge pull request #1 from romacron/patch-1
3c2e137 the db instancer called to late for sterr
01f5a5e By using more then one Colorpicker in a form the trigger must identif…
07b9fea Update media/system/css/mooRainbow.css
3c28b42 Update libraries/joomla/image/image.php

from the pull request. Better 1 pull request for one change?

Contributor

eddieajau commented Apr 8, 2012

Yeah, you need to make a new branch and put just those changes in there, and then make a new pull request. Avoid making changes to you fork's master or staging branch.

@eddieajau eddieajau closed this Apr 8, 2012

as LouisLandry commented, just rename to
public function __destruct()

@return boolean True on success or false on failure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.