This repository has been archived by the owner. It is now read-only.

Deprecate JXMLElement #1141

Merged
merged 2 commits into from Apr 13, 2012

Conversation

Projects
None yet
2 participants
@realityking
Contributor

realityking commented Apr 9, 2012

JXMLElement isn't all that useful anymore. It only has two methods, one is just an alias to an internal method of the parent class. The other can be replaced by a method of the parent class in most cases, in case people need to pretty print they can either move the method to their own code or use DOMDocument to do it for them.

@chdemko

View changes

libraries/joomla/installer/extension.php
@@ -86,13 +86,13 @@ class JExtension extends JObject
/**
* Constructor
*
- * @param JXMLElement $element A JXMLElement from which to load data from
+ * @param SimpleXMLElement $element A SimpleXMLElement from which to load data from
*
* @since 11.1
*/
public function __construct(JXMLElement $element = null)

This comment has been minimized.

@chdemko

chdemko Apr 11, 2012

Contributor

Change type to SimpleXMLElement

@chdemko

chdemko Apr 11, 2012

Contributor

Change type to SimpleXMLElement

This comment has been minimized.

@realityking

realityking Apr 11, 2012

Contributor

Done.

@realityking

realityking Apr 11, 2012

Contributor

Done.

@realityking

This comment has been minimized.

Show comment
Hide comment
@realityking

realityking Apr 11, 2012

Contributor

I left the tests intact for now to demonstrate B/C, we can change the later.

The 3 files you mentioned I didn't change because that would be a (small) B/C break, if we wanna do that we can do it in a later pull request.

Contributor

realityking commented Apr 11, 2012

I left the tests intact for now to demonstrate B/C, we can change the later.

The 3 files you mentioned I didn't change because that would be a (small) B/C break, if we wanna do that we can do it in a later pull request.

chdemko added a commit that referenced this pull request Apr 13, 2012

@chdemko chdemko merged commit aaf8ddf into joomla:staging Apr 13, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.