Skip to content

Deprecate JXMLElement #1141

Merged
merged 2 commits into from Apr 13, 2012

2 participants

@realityking
Joomla! member

JXMLElement isn't all that useful anymore. It only has two methods, one is just an alias to an internal method of the parent class. The other can be replaced by a method of the parent class in most cases, in case people need to pretty print they can either move the method to their own code or use DOMDocument to do it for them.

@chdemko chdemko and 1 other commented on an outdated diff Apr 11, 2012
libraries/joomla/installer/extension.php
@@ -86,13 +86,13 @@ class JExtension extends JObject
/**
* Constructor
*
- * @param JXMLElement $element A JXMLElement from which to load data from
+ * @param SimpleXMLElement $element A SimpleXMLElement from which to load data from
*
* @since 11.1
*/
public function __construct(JXMLElement $element = null)
@chdemko
chdemko added a note Apr 11, 2012

Change type to SimpleXMLElement

@realityking
Joomla! member
realityking added a note Apr 11, 2012

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@realityking
Joomla! member

I left the tests intact for now to demonstrate B/C, we can change the later.

The 3 files you mentioned I didn't change because that would be a (small) B/C break, if we wanna do that we can do it in a later pull request.

@chdemko chdemko merged commit aaf8ddf into joomla:staging Apr 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.