Check for install method versus discover_install #1145

merged 1 commit into from Apr 13, 2012


None yet
2 participants

mbabker commented Apr 10, 2012

In a rather odd twist, in the discover_install method of the component install adapter, we check if there is a discover_install method in the script file (which isn't documented anywhere as actually needed), which presumably causes this check to always fail. Should it succeed, the script file's install method is the one actually triggered.

This is one of two potential solutions to the problem. I've changed the check so that we check if the install method exists. The other option, which would need documenting, would be to use a discover_install method in the script files.

On an unrelated note, the component adapter is the only one which actually triggers the script file at discover_install, though it is supported in many other adapters, so once this is sorted out, the next goal is to get that support into the other adapters.

@chdemko chdemko added a commit that referenced this pull request Apr 13, 2012

@chdemko chdemko Merge pull request #1145 from mbabker/installer
Check for install method versus discover_install

@chdemko chdemko merged commit c3d1e63 into joomla:staging Apr 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment