Join GitHub today
JLog Exception, Class Name capitalization, and DBO #1159
Redid the PR that @LouisLandry reviewed with a fresh copy of core. Did not include the logic error issue. I doubt it's a problem and I need to study it more closely before testing again. I will add a new test for the single priority, single category logger when I get this review done.
The other changes are in this PR and all tests pass -
I also added the SQL change recommended by @realityking for the JDate/JDatabase object issue.
Appreciate everyone's help and feedback. Please let me know if changes are needed.
@realityking - with the exception of the autoloading, I (believe I) have addressed your points.
I added an option for using a break tag -- defaulting to current behavior so as to not change the output for existing CLI apps. Do you think this is an acceptable approach?
Thanks for your feedback and direction.
Looks good. A couple of code style issues to clean up: http://developer.joomla.org/pulls/pulls/1159.html
Also, I think we can get rid of the Test class for LogException. It doesn't do anything and adds no value. There isn't anything to test. As soon as the style issues are cleaned up I'll get it merged. Thanks for the work Amy.