This repository has been archived by the owner. It is now read-only.

Remove JText dependency on JStreamString for die Statement #1165

Merged
merged 1 commit into from Apr 22, 2012

Conversation

Projects
None yet
2 participants
Contributor

AmyStephen commented Apr 21, 2012

The only occurrence of JText in this class is to translate the die Statement. Doesn't seem worth a dependency.

Contributor

LouisLandry commented Apr 22, 2012

To be honest I'd rather see us throw an exception than die in a case like this, but for the sake of removing coupling I'll allow it this time ;-)

LouisLandry added a commit that referenced this pull request Apr 22, 2012

Merge pull request #1165 from AmyStephen/JStreamString
Remove JText dependency on JStreamString for die Statement

@LouisLandry LouisLandry merged commit 40d7a23 into joomla:staging Apr 22, 2012

Contributor

AmyStephen commented Apr 22, 2012

@LouisLandry - Good point. Listen - you are the one with the big picture in mind, so throw it back with direction or close it if it's not right. I appreciate the direction as it helps me understand what "uncoupled" means to the platform team and some of the finer points of what you are working towards in the framework. So, that type of feedback (should) help me be more useful. ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.