Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Code Cleanup #1182

Merged
merged 1 commit into from

2 participants

@simonharrer

Removed unused variables and unused variable initializations.

@realityking
Collaborator

Thanks!

@realityking realityking merged commit e27be38 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
1  libraries/joomla/cache/controller/callback.php
@@ -94,7 +94,6 @@ public function get($callback, $args = array(), $id = false, $wrkarounds = false
$id = $this->_makeId($callback, $args);
}
- $data = false;
$data = $this->cache->get($id);
$locktest = new stdClass;
View
3  libraries/joomla/cache/controller/page.php
@@ -49,9 +49,6 @@ class JCacheControllerPage extends JCacheController
*/
public function get($id = false, $group = 'page', $wrkarounds = true)
{
- // Initialise variables.
- $data = false;
-
// If an id is not given, generate it from the request
if ($id == false)
{
View
1  libraries/joomla/cache/controller/view.php
@@ -38,7 +38,6 @@ public function get(&$view, $method, $id = false, $wrkarounds = true)
$id = $this->_makeId($view, $method);
}
- $data = false;
$data = $this->cache->get($id);
$locktest = new stdClass;
View
1  libraries/joomla/cache/storage/cachelite.php
@@ -92,7 +92,6 @@ protected function initCache($cloptions)
*/
public function get($id, $group, $checkTime = true)
{
- $data = false;
self::$CacheLiteInstance->setOption('cacheDir', $this->_root . '/' . $group . '/');
$this->_getCacheId($id, $group);
$data = self::$CacheLiteInstance->get($this->rawname, $group);
View
2  libraries/joomla/installer/adapters/component.php
@@ -1299,8 +1299,6 @@ protected function _buildAdminMenus()
$this->parent->pushStep(array('type' => 'menu', 'id' => $component_id));
}
- $parent_id = $table->id;
-
/*
* Process SubMenus
*/
View
3  libraries/joomla/installer/adapters/package.php
@@ -301,8 +301,6 @@ public function install()
if ($this->get('manifest_script'))
{
// First, we have to create a folder for the script if one isn't present
- $created = false;
-
if (!file_exists($this->parent->getPath('extension_root')))
{
JFolder::create($this->parent->getPath('extension_root'));
@@ -511,7 +509,6 @@ public function uninstall($id)
protected function _getExtensionID($type, $id, $client, $group)
{
$db = $this->parent->getDbo();
- $result = $id;
$query = $db->getQuery(true);
$query->select('extension_id');
View
2  libraries/joomla/installer/installer.php
@@ -875,8 +875,6 @@ public function parseSQLFiles($element)
}
// Get the name of the sql file to process
- $sqlfile = '';
-
foreach ($element->children() as $file)
{
$fCharset = (strtolower($file->attributes()->charset) == 'utf8') ? 'utf8' : '';
View
2  libraries/joomla/updater/adapters/collection.php
@@ -182,7 +182,7 @@ public function _startElement($parser, $name, $attrs = array())
*/
protected function _endElement($parser, $name)
{
- $lastcell = array_pop($this->stack);
+ array_pop($this->stack);
switch ($name)
{
case 'CATEGORY':
Something went wrong with that request. Please try again.