This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Unify the checking of the platform. #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Define a boolean constant as true if a Mac based host | ||
| define('JPATH_ISMAC', (strtoupper(substr(PHP_OS, 0, 3)) === 'MAC')); | ||
|
|
||
| if (!defined('JPATH_ROOT')) |
There was a problem hiding this comment.
Could we have a B/C issue by removing these constants?
There was a problem hiding this comment.
Yeah we do. We could move the to the import.legacy.php folder, make them aliases of IS_WIN and IS_MAC and deprecate them. What do you think?
|
it's a good solution |
chdemko
added a commit
that referenced
this pull request
Jun 26, 2012
Unify the checking of the platform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standardizes everything on the IS_WIN/IS_MAC/IS_UNIX constants. JApplication::isWinOS() is only deprecated for legacy purposes.