This repository has been archived by the owner. It is now read-only.

JSession: Removed duplicated code, code style #1329

Merged
merged 2 commits into from Jun 30, 2012

Conversation

Projects
None yet
2 participants
Contributor

piotr-cz commented Jun 30, 2012

Minor fixes not affecting functionality

- return true;
- }
- return false;
+ return (bool) ($counter === 1)
@realityking

realityking Jun 30, 2012

Contributor

You're missing the ; at the end of the line.

@piotr-cz

piotr-cz Jun 30, 2012

Contributor

Thanks, fixed.

I don't understand why there is a typecast to boolean in JSession->isActive and I repeated the style. Should I remove these?

@realityking

realityking Jun 30, 2012

Contributor

However you want, it's not needed but personally I don't mind it.

@piotr-cz

piotr-cz Jun 30, 2012

Contributor

Lets keep it then

realityking added a commit that referenced this pull request Jun 30, 2012

Merge pull request #1329 from piotr-cz/JHttp-JSession_codestyle
JSession: Removed duplicated code, code style

@realityking realityking merged commit b697d69 into joomla:staging Jun 30, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.