This repository has been archived by the owner. It is now read-only.

fix issue #1467(JHtml::calendar does not format dates on output correctly) #1468

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
4 participants
@ramalama
Contributor

ramalama commented Aug 18, 2012

No description provided.

@realityking

This comment has been minimized.

Show comment
Hide comment
@realityking

realityking Aug 18, 2012

Contributor

Is still still working with the JS calendar? With non-gregorian calendars?

Contributor

realityking commented Aug 18, 2012

Is still still working with the JS calendar? With non-gregorian calendars?

@elinw

This comment has been minimized.

Show comment
Hide comment
@elinw

elinw Aug 18, 2012

Contributor

Would you please change this title to something that describes the issue? The title is used for creating the changelog.

Contributor

elinw commented Aug 18, 2012

Would you please change this title to something that describes the issue? The title is used for creating the changelog.

@ramalama

This comment has been minimized.

Show comment
Hide comment
@ramalama

ramalama Aug 18, 2012

Contributor

@realityking It is still working with the DHTML JS Calendar, but I don't know how to check the non-gergorian calendars.
@elinw changed the title, hope that it's better now.

Contributor

ramalama commented Aug 18, 2012

@realityking It is still working with the DHTML JS Calendar, but I don't know how to check the non-gergorian calendars.
@elinw changed the title, hope that it's better now.

@realityking

This comment has been minimized.

Show comment
Hide comment
@realityking

realityking Aug 20, 2012

Contributor

I suggest you talk to JM about non-gregorian calendars, he knows most about it.

You also have code style issues and a unit test failure to address: http://developer.joomla.org/pulls/pulls/1468.html

Contributor

realityking commented Aug 20, 2012

I suggest you talk to JM about non-gregorian calendars, he knows most about it.

You also have code style issues and a unit test failure to address: http://developer.joomla.org/pulls/pulls/1468.html

ramalama added some commits Aug 21, 2012

Added correct format to test data
Input 2010-05-28 00:00:00 should result in  2010-05-28 if the format is
'%Y-%m-%d"
Input 2010-05-28 00:00:00 should result in  2010-05-28 00:00:00 if the
format is '%Y-%m-%d %H:%M:%i"
Fixed mistake in format string
additionally changed the time string to a better value, where hour, min
and seconds values differ.
@LouisLandry

This comment has been minimized.

Show comment
Hide comment
@LouisLandry

LouisLandry Oct 9, 2012

Contributor

@ramalama this pull request is no longer mergeable. It would be great if you could rebase it (and maybe squash some of the commits) so that it is mergeable again. Apologies for the long delay in response. Once you get it cleaned up we can take a quick look at the internationalization issues brought up and hopefully get it merged into the platform.

Note: I'm closing the pull request for now. This isn't because I'm rejecting it, but because in its current state it cannot be reviewed. Once you get it rebased and cleaned up please re-open the pull request and we'll finish the conversation on getting it merged. Thanks!

Contributor

LouisLandry commented Oct 9, 2012

@ramalama this pull request is no longer mergeable. It would be great if you could rebase it (and maybe squash some of the commits) so that it is mergeable again. Apologies for the long delay in response. Once you get it cleaned up we can take a quick look at the internationalization issues brought up and hopefully get it merged into the platform.

Note: I'm closing the pull request for now. This isn't because I'm rejecting it, but because in its current state it cannot be reviewed. Once you get it rebased and cleaned up please re-open the pull request and we'll finish the conversation on getting it merged. Thanks!

@LouisLandry LouisLandry closed this Oct 9, 2012

@ramalama

This comment has been minimized.

Show comment
Hide comment
@ramalama

ramalama Oct 20, 2012

Contributor

@LouisLandry I am sorry, I do not know how to rebase it and do not have time to do this these days.

Contributor

ramalama commented Oct 20, 2012

@LouisLandry I am sorry, I do not know how to rebase it and do not have time to do this these days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.