Skip to content

fix issue #1467(JHtml::calendar does not format dates on output correctly) #1468

Closed
wants to merge 6 commits into from

4 participants

@ramalama

No description provided.

@realityking
Joomla! member

Is still still working with the JS calendar? With non-gregorian calendars?

@elinw
elinw commented Aug 18, 2012

Would you please change this title to something that describes the issue? The title is used for creating the changelog.

@ramalama

@realityking It is still working with the DHTML JS Calendar, but I don't know how to check the non-gergorian calendars.
@elinw changed the title, hope that it's better now.

@realityking
Joomla! member

I suggest you talk to JM about non-gregorian calendars, he knows most about it.

You also have code style issues and a unit test failure to address: http://developer.joomla.org/pulls/pulls/1468.html

ramalama added some commits Aug 21, 2012
@ramalama ramalama Code Style Issues solved e9e62ac
@ramalama ramalama Added correct format to test data
Input 2010-05-28 00:00:00 should result in  2010-05-28 if the format is
'%Y-%m-%d"
Input 2010-05-28 00:00:00 should result in  2010-05-28 00:00:00 if the
format is '%Y-%m-%d %H:%M:%i"
13101c0
@ramalama ramalama Fixed mistake in format string
additionally changed the time string to a better value, where hour, min
and seconds values differ.
c13fd46
@LouisLandry

@ramalama this pull request is no longer mergeable. It would be great if you could rebase it (and maybe squash some of the commits) so that it is mergeable again. Apologies for the long delay in response. Once you get it cleaned up we can take a quick look at the internationalization issues brought up and hopefully get it merged into the platform.

Note: I'm closing the pull request for now. This isn't because I'm rejecting it, but because in its current state it cannot be reviewed. Once you get it rebased and cleaned up please re-open the pull request and we'll finish the conversation on getting it merged. Thanks!

@LouisLandry LouisLandry closed this Oct 9, 2012
@ramalama

@LouisLandry I am sorry, I do not know how to rebase it and do not have time to do this these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.