When using the Updater in Joomla 3 right now you get a:
Checking with Rouven he suggested that change attached in the pull request. I have tested with the 3 transports like that:
// using STREAM
$http = new JHttp(null, new JHttpTransportStream(null));
// using sockets
$http = new JHttp(null, new JHttpTransportSocket(null));
// using CURL
$http = JHttpFactory::getHttp();
All they worked for me.
Please review it.
Fix installer/updater in platform for Joomla 3.
Sorry, I made a mistake during the test. Actually is not working for Stream and Sockets. Only for CURL
I'm wondering here first why Content-Disposition would be found outside of the wrapper_data. Would it possibly be better to check if $response->headers['wrapper_data']['Content-Disposition']) is !empty? Since it's optional it's valid for it to not be set or to be empty.
@realityking, is this change apply to all 3 adapters ? (curl, socket, stream)
Maybe I'm overlooking a key thing here. I understood JHttpResponse::$transport to be an array of all the headers returned by the server. The keys being the header name and the value being the value.
As far as I can tell wrapper_data is something stream specific, if this is the case we should abstract this out in the JHttp transports.
@oc666 I'm not sure what you're asking, this code is outside JHttp, in theory it shouldn't concern itself with the question what transport is used.