Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add error handling for __get and __call methods. #1517
Adding a __get or __call method may mask errors about unexisting method or properties if we don't do our own error handling. This pull should provide appropriate errors for all of these.
Note: The test results will show one error in JTableNested that I suspect is an actual bug but I'm not sure how to fix.
I'm guessing it should be $this->_unlock() instead since that is a valid method of JTable.
I found where it was added to the file here:
Even at that commit, JDatabaseQuery doesn't support lock and for some reason it's having a database object fed into it as well which seems a bit strange. Given almost every other occurrence in the file has been removed I think swapping this back to $this->_unlock() is probably the correct change.