Skip to content

CMS [#25663] Fixes build admin menu item error while (re)installing componen... #1558

Merged
merged 2 commits into from Oct 2, 2012

3 participants

@nikosdion

+1 Seems to work just fine.

@pasamio
pasamio commented Sep 30, 2012

Can you fix the style issues with this pull request? To verify you'll need to install PHPCS[1] and get the Joomla code standard[2].

I've included a quick copy of the errors below:

Concat operator must be followed by one space.
 .../libraries/joomla/installer/adapters/component.php : 1274
Concat operator must be preceeded by one space.
 .../libraries/joomla/installer/adapters/component.php : 1274
Concat operator must be followed by one space.
 .../libraries/joomla/installer/adapters/component.php : 1276
Concat operator must be preceeded by one space.
 .../libraries/joomla/installer/adapters/component.php : 1276
Concat operator must be followed by one space.
 .../libraries/joomla/installer/adapters/component.php : 1276
Concat operator must be preceeded by one space.
 .../libraries/joomla/installer/adapters/component.php : 1276
Concat operator must be followed by one space.
 .../libraries/joomla/installer/adapters/component.php : 1277
Concat operator must be preceeded by one space.
 .../libraries/joomla/installer/adapters/component.php : 1277
Expected "if (...)\n...{...}\n...else\n"; found "if(...) ...{...} ...else ".
 .../libraries/joomla/installer/adapters/component.php : 1284
Concat operator must be followed by one space.
 .../libraries/joomla/installer/adapters/component.php : 1292
Concat operator must be preceeded by one space.
 .../libraries/joomla/installer/adapters/component.php : 1292
Cast statements must be followed by a single space; expected "(int) $menu_id" but found "(int)$menu_id".
 .../libraries/joomla/installer/adapters/component.php : 1292
Expected "if (...)\n...{...}\n...else\n"; found "if (...) ...{...}\n...else\n".
 .../libraries/joomla/installer/adapters/component.php : 1299

[1] http://pear.php.net/package/PHP_CodeSniffer/
[2] https://github.com/joomla/coding-standards

@pjwiseman

Applied coding standards. Thanks Sam for instructions.

@pasamio pasamio merged commit 963588c into joomla:staging Oct 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.