Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Improvments to getJSObject #1566

Merged
merged 2 commits into from Oct 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

okonomiyaki3000 commented Oct 5, 2012

Resources are ignored
Object keys and strings are encoded with json_encode
If the input array contains (php) objects, their values are used for recursion rather than the objects themselves (the function takes an array, not an object)
Less string concatenation, more array implosion

okonomiyaki3000 added some commits Oct 5, 2012

@okonomiyaki3000 okonomiyaki3000 Improvments to getJSObject
	Resources are ignored
	Object keys and strings are encoded with json_encode
	If the input array contains (php) objects, their values are used for recursion rather than the objects themselves (the function takes an array, not an object)
	Less string concatenation, more array implosion
0d9e920
@okonomiyaki3000 okonomiyaki3000 remove trailing whitespace 2771572
Contributor

LouisLandry commented Oct 5, 2012

Nice. Thanks!

@LouisLandry LouisLandry added a commit that referenced this pull request Oct 5, 2012

@LouisLandry LouisLandry Merge pull request #1566 from okonomiyaki3000/JHTML-improve-getJSObject
Improvments to getJSObject
f1dfc46

@LouisLandry LouisLandry merged commit f1dfc46 into joomla:staging Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment