This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Set param for file to load with render method #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not default it to index.php instead of requiring each implementation to define a default? Theme path I can understand as being needed to be configured, but index.php is a pretty safe bet for a file name. |
|
I forgot get allows a default value. I'll fix it in a bit. |
|
OK, that's changed. |
LouisLandry
added a commit
that referenced
this pull request
Oct 7, 2012
Set param for file to load with render method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to JApplicationWeb::render() allows downstream users to set a file to load using the same methods as the template and params values are set with. For example, in the CMS, we would have to override this method to use the tmpl=component URL param. Now, it's just another param to set.