Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Completing tests for JModelLegacy #1588

Merged
merged 1 commit into from Oct 10, 2012
Merged

Completing tests for JModelLegacy #1588

merged 1 commit into from Oct 10, 2012

Conversation

dongilbert
Copy link
Contributor

Here are the completed tests for JModelLegacy.

@LouisLandry
Copy link
Contributor

Great stuff. You can improve the bit where you are testing the exception a little by looking over: http://www.phpunit.de/manual/current/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.exceptions

Also, for extra points you can fix up all the code styling and docblocks, etc to take after: https://github.com/joomla/joomla-platform/blob/staging/tests/suites/unit/joomla/model/JModelDatabaseTest.php

@dongilbert
Copy link
Contributor Author

Will do. Also, I'm going to refactor to use fixtures and the setUp() and tearDown() functions, instead of calling JModelLegacy::getInstance() everywhere.

cleaning up code styling and refactor code to use fixtures
ianmacl pushed a commit that referenced this pull request Oct 10, 2012
Completing tests for JModelLegacy
@ianmacl ianmacl merged commit 169fa52 into joomla:staging Oct 10, 2012
@ianmacl
Copy link
Contributor

ianmacl commented Oct 10, 2012

Merged. Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants