Skip to content

Completing tests for JModelLegacy #1588

Merged
merged 1 commit into from Oct 10, 2012

3 participants

@dongilbert

Here are the completed tests for JModelLegacy.

@LouisLandry

Great stuff. You can improve the bit where you are testing the exception a little by looking over: http://www.phpunit.de/manual/current/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.exceptions

Also, for extra points you can fix up all the code styling and docblocks, etc to take after: https://github.com/joomla/joomla-platform/blob/staging/tests/suites/unit/joomla/model/JModelDatabaseTest.php

@dongilbert

Will do. Also, I'm going to refactor to use fixtures and the setUp() and tearDown() functions, instead of calling JModelLegacy::getInstance() everywhere.

@dongilbert dongilbert Completing tests for JModelLegacy
cleaning up code styling and refactor code to use fixtures
868c542
@ianmacl ianmacl merged commit 169fa52 into joomla:staging Oct 10, 2012
@ianmacl
ianmacl commented Oct 10, 2012

Merged. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.