This repository has been archived by the owner. It is now read-only.

fixing JTable::addIncludePaths and updating unit tests #1610

wants to merge 1 commit into


None yet
1 participant

dongilbert commented Oct 17, 2012

When passed paths that already exist in the $_includePaths array, JTable::addIncludePath mistakenly re-adds them. This is due to the fact that before !in_array($path, self::$_includePaths) runs, $path is converted to an array. This was to facilitate the ability to pass either an array of paths or a path string to the method. However, it also caused the in_array function to check $_includePaths as a multi-dimensional array, when it is only ever a single-dimensional array. This code fixes that behavior. I've included tests as well.

@dongilbert dongilbert closed this Oct 17, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.