JMediawiki Package for Joomla #1624

Merged
merged 3 commits into from Mar 17, 2013

Projects

None yet

5 participants

@nprasath002
Contributor

JMediawiki Package for Joomla. All methods are not covered by unit tests.

Looking at the pull request tester there are some CS errors: http://developer.joomla.org/pulls/pulls/1624.html think you can fix those?

Contributor

Fixed should be ok now. Is there a way we can run these tests externally?
How can i run the pull tester?

Contributor
elinw commented Oct 21, 2012

Install phpunit and phpcs locally and you can run them there. There are some instructions on the wiki linked above.I

Contributor

There are still some code style errors in this package.

http://developer.joomla.org/pulls/pulls/1624.html

If you can fix them over the weekend I'll merge the code.

Contributor

Since it's line ending issues, I'll merge this and then fix them right away. Thanks for your work on this.

@dongilbert dongilbert merged commit 7466fcc into joomla:staging Mar 17, 2013
Contributor

Cleaned everything up here: 71f3311

@mbabker mbabker referenced this pull request in joomla/joomla-framework May 21, 2014
Closed

Port API packages from CMS #297

1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment