Clean any white spaces and/or tabs #1705

Merged
merged 1 commit into from Nov 19, 2012

2 participants

@mariopro

Tabs that may result from manifest source formatting after the translation element
in

COM_COMPONENT_SUBMENUNAME result in invisible bugs as the translation element is saved to the #__menu table with the tabs/white spaces.
Translation will not be done and the alias will be used by the system to build the menu or submenu.
Hard to debug, since white spaces and tabs are invisible in database.
Suggestion is to trim both $menuElement and $child in the _buildAdminMenus method to avoid this issue.

mariopro Clean any white spaces and/or tabs
Tabs that may result from manifest source formatting after the translation element
in <submenu><menu>COM_COMPONENT_SUBMENUNAME</menu></submenu> result in invisible bugs as the translation element is saved to the #__menu table with the tabs/white spaces.
Translation will not be done and the alias will be used by the system to build the menu or submenu.
Hard to debug, since white spaces and tabs are invisible in database.
Suggestion is to trim both $menuElement and $child in the _buildAdminMenus method to avoid this issue.
d706f8c
@pasamio

Can you update to trim the alias as well?

@mariopro

The alias is not affected because the building process of the alias, per se, trims the alias before it is saved to the database. On my tests, I didn't find spaces or tabs in the alias db field, so that's the reason it wasn't contemplated here.

@pasamio pasamio merged commit ae75c7a into joomla:staging Nov 19, 2012
@pasamio

Fair enough :)

@mariopro

Thanks

@mariopro mariopro deleted the unknown repository branch Feb 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment