Allows JViewHtml->getPath to set the extension of the layout file. #1735

Merged
merged 2 commits into from Dec 22, 2012

Projects

None yet

4 participants

@eddieajau
Contributor

This pull allows for a different extension to be set for the layout file. Adding a default extension to getPath easily allows the developer to derive their own views with a new default.

@elinw
Contributor
elinw commented Dec 3, 2012

:) So we can easily switch from php to phtml (and back)? +1

@eddieajau
Contributor

It's not perfect but it's a first step. The thing it solves is you having to completely duplicate the getPath method which is what you have to do at the moment to get around this. More could be done in the future but this scratches and itch.

@elinw
Contributor
elinw commented Dec 3, 2012

That's great; it's something that has been on my mind too.

@drmmr763
drmmr763 commented Dec 3, 2012

I like the sounds of this!

On Monday, December 3, 2012, elinw wrote:

That's great; it's something that has been on my mind too.


Reply to this email directly or view it on GitHubhttps://github.com/joomla/joomla-platform/pull/1735#issuecomment-10943346.


[image: Small Logo] http://www.s-go.net/
Chad Windnagle
s-go Consulting
607-330-2574 x103
607-229-6260 (Cell)
Website Design - SEO - Video http://www.s-go.net/

Follow Me: [image: Facebook] http://www.facebook.com/sgoconsulting [image:
LinkedIn] http://www.linkedin.com/in/drmmr763 [image:
Twitter]http://www.twitter.com/drmmr763

@pasamio
Contributor
pasamio commented Dec 20, 2012

This pull request cannot be automatically merged, looks like it'll need an update.

eddieajau added some commits Dec 4, 2012
@eddieajau eddieajau Fix and expand JDatabaseQuery tests.
Fixed mocking of the quote method in TestMockDatabaseDriver to allow for
an array of strings to be quoted.
Fixed a bug in JDatabaseQuery->quote that escaped strings before sending
them to the JDatabaseDriver->quote method ($escape argument was not
being honoured).
Added the escape method to TestMockDatabaseDriver.
Added covers to and improved code coverage of the JDatabaseQuery class.
ce6db9b
@eddieajau eddieajau Allows JViewHtml->getPath to set the extension of the layout file.
Allows for a different extension to be set for the layout
file. Adding a default extension to getPath easily allows the developer
to derive their own views with a new default.
dc78ff9
@eddieajau
Contributor

Fixed, but please merge #1737 first.

@pasamio
Contributor
pasamio commented Dec 22, 2012

I think GitHub actually has the smarts to work out that the original one is merged but I've merged it.

@pasamio pasamio merged commit 1071080 into joomla:staging Dec 22, 2012
@pasamio
Contributor
pasamio commented Dec 22, 2012

As an aside, there appears to have been issues with a recent pull request:
http://build.joomla.org/job/platform/1186/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment