Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

JUser bind #1741

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

fanno commented Dec 7, 2012

...w users because the values are not yet set, Fixed by moving the check below setProperties

also see:
https://groups.google.com/forum/?fromgroups=#!topic/joomlabugsquad/ggmaWUzb-lM

This is my first pull request so bare with me

Fixed issue with the password and username check is not preformed for…
… new users because the values are not yet set, Fixed by moving the check below setProperties

@eddieajau eddieajau commented on the diff Dec 8, 2012

libraries/joomla/user/user.php
@@ -615,6 +597,24 @@ public function bind(&$array)
return false;
}
+ // Check that username is not greater than 150 characters
@eddieajau

eddieajau Dec 8, 2012

Contributor

Seems to be one too many indents here?

@fanno

fanno Dec 8, 2012

Contributor

This is my first pull request so i do not know what the normal process is ? i do not understand your comment/note ??

Contributor

eddieajau commented Dec 8, 2012

I don't suppose you're able to do the unit test for the bind method while you are at it?

Contributor

fanno commented Dec 8, 2012

sure i can, i just don't know how, is there a tutorial for it somewhere ?

Contributor

fanno commented Dec 8, 2012

hmm should the check for to long password not throw an error ? now that i have looked a bit more at it? or else how would you be able to check the login if the salt has changed because it have been cut down in length ? (just thinking out laud)

Contributor

fanno commented Dec 8, 2012

like this ?
#1743

@fanno fanno closed this Dec 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment