This repository has been archived by the owner. It is now read-only.

Fix #29692, fix default value of "client_id" #1749

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@pilou-

pilou- commented Dec 11, 2012

client_id: use "0" as default value.

@pasamio

This comment has been minimized.

Show comment Hide comment
@pasamio

pasamio Dec 15, 2012

Contributor

Can you elaborate a little more on this issue?

Contributor

pasamio commented Dec 15, 2012

Can you elaborate a little more on this issue?

@pilou-

This comment has been minimized.

Show comment Hide comment
@pasamio

This comment has been minimized.

Show comment Hide comment
@pasamio

pasamio Dec 16, 2012

Contributor

Sure, but why does this fix the problem? Is it just that the menu isn't loaded or that something is missing? Is it a check while it's being created that isn't initialised properly? I'd suggest defaulting the property in the table class in general instead of setting it in the constructor as it allows the children to override it easier and it isn't dependent upon any other parameters.

I don't see why this is being quoted as a string when it should be treated as an integer value and that should solve the problem. More importantly I'm worried that something isn't binding data appropriately somewhere.

29685: This is probably a field set incorrectly, I'd suggest that it should update the schema instead. A default value might solve the problem but likely the field should probably be reset to have a default value of an empty string.
29678: I'd suggest much the same as the above.
29680: Sounds like someone is quoting integers again instead of converting them to an integer.

Contributor

pasamio commented Dec 16, 2012

Sure, but why does this fix the problem? Is it just that the menu isn't loaded or that something is missing? Is it a check while it's being created that isn't initialised properly? I'd suggest defaulting the property in the table class in general instead of setting it in the constructor as it allows the children to override it easier and it isn't dependent upon any other parameters.

I don't see why this is being quoted as a string when it should be treated as an integer value and that should solve the problem. More importantly I'm worried that something isn't binding data appropriately somewhere.

29685: This is probably a field set incorrectly, I'd suggest that it should update the schema instead. A default value might solve the problem but likely the field should probably be reset to have a default value of an empty string.
29678: I'd suggest much the same as the above.
29680: Sounds like someone is quoting integers again instead of converting them to an integer.

@eddieajau

This comment has been minimized.

Show comment Hide comment
@eddieajau

eddieajau Mar 16, 2013

Contributor

Doesn't appear to be a resolution here. Closing.

Contributor

eddieajau commented Mar 16, 2013

Doesn't appear to be a resolution here. Closing.

@eddieajau eddieajau closed this Mar 16, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.