Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update libraries/joomla/database/driver/sqlsrv.php #1818

Merged
merged 1 commit into from Apr 14, 2013

Conversation

Projects
None yet
3 participants
Contributor

MDunkleSr commented Jan 31, 2013

Add ' ORDER BY RowNumber' to limit(). Without ORDER BY, limit function returns results that do not honor the original ORDER BY specified in the query.

@MDunkleSr MDunkleSr Update libraries/joomla/database/driver/sqlsrv.php
Add ' ORDER BY RowNumber' to limit(). Without ORDER BY, limit function returns results that do not honor the original ORDER BY specified in the query.
5b983e1
Contributor

dongilbert commented Mar 18, 2013

If someone with sqlsrv access can confirm this, I think it's good to merge. @mbabker? (Sorry, always picking on you.)

Contributor

MDunkleSr commented Mar 18, 2013

Not that it changes the need for independent confirmation, but I do have it running w/ desired results in both a test & production environment. LMK if I need to clarify anything.

Appreciate you taking a look at this & considering it for merge!

Thanks,

Mike

Contributor

dongilbert commented Mar 18, 2013

That's good to know. I trust testing and production usage more than one off testing, TBH. I just don't have access to sqlsrv (that I know of) to test it myself.

Owner

mbabker commented Mar 28, 2013

I'll be firing up my Windows & SQL Server environment this weekend for some CMS work, but I'll add this to my to-do list as well.

@dongilbert dongilbert added a commit that referenced this pull request Apr 14, 2013

@dongilbert dongilbert Merge pull request #1818 from MDunkleSr/patch-3
Update libraries/joomla/database/driver/sqlsrv.php
7172fb5

@dongilbert dongilbert merged commit 7172fb5 into joomla:staging Apr 14, 2013

@MDunkleSr MDunkleSr deleted the MDunkleSr:patch-3 branch Apr 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment