Allow chaining of JDocumentHTML setHtml5 like in other methods #1827

Merged
merged 1 commit into from Feb 24, 2013

Projects

None yet

3 participants

@piotr-cz
Contributor

Allow chaining of JDocumentHTML setHtml5 like in other methods, ie:

JFactory::getDocument()
    ->setTitle($this->get('sitename', 'Website'))
    ->setDescription($this->get('MetaDesc'))
    ->setHtml5(true)
;
@dongilbert
Contributor

Looks good and makes sense. If you're able to, could you write a unit test for this change? Currently, JDocumentHTML has 0 tests written, so it would be nice to start here.

https://github.com/joomla/joomla-platform/blob/staging/tests/suites/unit/joomla/document/html/JDocumentHTMLTest.php

@piotr-cz
Contributor

I'll try to.

@eddieajau eddieajau merged commit ece5d2b into joomla:staging Feb 24, 2013
@eddieajau
Contributor

Would be great if you could add tests, but the actual change is fine.

@piotr-cz
Contributor

@eddieajau
I'll try to, but I'm quite busy with work at the moment and I'm completely fresh to unit testing.

@piotr-cz piotr-cz deleted the unknown repository branch Feb 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment