This repository has been archived by the owner. It is now read-only.

Added Repositories API calls for JGithub #1835

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

This small additions adds the required APIs for listing repositories using JGithub

Contributor

dongilbert commented Feb 19, 2013

This looks good - It's another needed addition. Can you add unit tests for this?

In the near future i hope to be able to. I added this class for a project i'll present at JAB13 and thought to share it since it could've been needed.

Contributor

dongilbert commented Feb 19, 2013

Very cool - thanks for the work. There's another pull request that
completely refactors JGithub and already contains code for fetching
repositories data, but it breaks backwards compatibility. So, we may not be
merging that here, but instead release it separately. So, yours is still
needed.

There are also going to be some code style issues due to improper spacing
in your code, but I don't have a link to provide for you to review the
errors, since the checkstyle process hasn't run yet. Once it does, I'll
post it so you can review.

On Tue, Feb 19, 2013 at 10:50 AM, Daniele Rosario
notifications@github.comwrote:

In the near future i hope to be able to. I added this class for a project
i'll present at JAB13 and thought to share it since it could've been
needed.


Reply to this email directly or view it on GitHubhttps://github.com/joomla/joomla-platform/pull/1835#issuecomment-13783172.

Yeah i feared that, as soon as the checks are done i'll take a look at them and correct for sure. Hope to be albe to put together some Unit tests too

Member

elkuku commented Feb 19, 2013

There's another pull request that completely refactors JGithub and already contains code for fetching repositories data, but it breaks backwards compatibility. So, we may not be merging that here, but instead release it separately. So, yours is still needed.

That's interesting info...
I assume you are talking about #1820.
Would it be possible to add a small note there regarding what you (the maintainers) are thinking about it ?

Thanks.

Contributor

eddieajau commented Mar 16, 2013

I'm going to close this one but will say can you work with @elkuku and his branch and let's get it updated in the Framework.

@eddieajau eddieajau closed this Mar 16, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.