Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

add attribution and fix several bugs #1850

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

pwfisher commented Mar 16, 2013

When you refactored my code, you introduced a few bugs.

You need to handle the case where the parameter value contains an equals sign.

You're also not handling the case where the next argument is something like -abc (starting with a single hyphen).

Also, don't overwrite a previously set string value with a boolean value.

add attribution and fix several bugs
When you refactored my code, you introduced a few bugs.

You need to handle the case where the parameter value contains an equals sign.

You're also not handling the case where the next argument is something like -abc (starting with a single hyphen).

Also, don't overwrite a previously set string value with a boolean value.
Contributor

dongilbert commented Mar 16, 2013

We didn't use your code as a base for this, as your code was created on github a total of 16 hours ago. Also, you are spamming several projects on github trying to get them to give you attribution for code you didn't create within their project. Please, stop the madness.

@dongilbert dongilbert closed this Mar 16, 2013

Contributor

pwfisher commented Mar 16, 2013

Even if you don't believe I wrote this, why would you ignore the bugfixes?

Owner

mbabker commented Mar 16, 2013

If you would like the bug fixes to be considered, please submit them
separately from the attribution change. Internally, we will discuss where
the original writer came up with this code and act accordingly for
attribution purposes.

On Saturday, March 16, 2013, Patrick Fisher wrote:

Even if you don't believe I wrote this, why would you ignore the bugfixes?


Reply to this email directly or view it on GitHubhttps://github.com/joomla/joomla-platform/pull/1850#issuecomment-15012175
.

Contributor

eddieajau commented Mar 16, 2013

Even if you don't believe I wrote this, why would you ignore the bugfixes?

There is no disputing you probably own the code in the patch, but I'm pretty sure you aren't the original owner of our code (because you said "When you refactored my code").

If you want us to consider this patch, then you need to follow the instructions here:
https://github.com/joomla/joomla-platform/blob/staging/CONTRIBUTING.markdown

Make sure you sign the JCA. Part of the deal with Joomla is that we don't attribute in the code itself. If that's a problem for you, I understand and we'll miss you.

Contributor

pwfisher commented Mar 16, 2013

Reconsidering it, I can't say with certainly that this was derived from my code. I think a drop-in replacement would be the best solution to the logic issues. I'll see what I can put together.

Contributor

eddieajau commented Mar 16, 2013

Make sure you add extra unit test cases to cover the bugs you are fixing. Thanks.

Contributor

pwfisher commented Mar 16, 2013

Please see #1851 for the new function and unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment