Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix a regression with controllers for specific formats. #310

Merged
merged 2 commits into from Nov 24, 2011

Conversation

Projects
None yet
5 participants
Contributor

realityking commented Aug 29, 2011

No description provided.

Contributor

eddieajau commented Sep 8, 2011

Rouven, would you mind adding a list of the paths that this is supposed to be looking for. Then I'll have a think about how to craft a unit test for it. Thanks!

Contributor

realityking commented Sep 10, 2011

Sorry, took me a little bit longer.

Without this patch paths like this are used:

If the task contains a dot, e.g. articles.save (only the part before the dot is used):
BASE_PATH/controllers/articles.format.php

If the task doesn't contain a dot:
BASE_PATH/controllers/controller.format.php

The BASE_PATH is JPATH_COMPONENT if not overwritten.
Format can be XML, JSON and so on, if it is HTML it is omitted.

No with the pull we change the behavior when the task doesn't contain a dot:
If BASE_PATH/controllers/controller.format.php doesn't exist but BASE_PATH/controllers/controller.php does we use the later.

Is that we you need?

jlover commented Nov 2, 2011

Checkstyle error details:
libraries/joomla/application/component/controller.php:272
Concat operator must be surrounded by spaces
libraries/joomla/application/component/controller.php:272
Concat operator must be surrounded by spaces
libraries/joomla/application/component/controller.php:282
Expected "if (...)\n...{...}\n...else\n"; found "if (...)\n...{...}\n...else "
libraries/joomla/application/component/controller.php:286
Usage of ELSE IF is not allowed; use ELSEIF instead

Build triggered by changes to the base.

Test log missing. Tests failed to execute.
Checkstyle analysis reported 233 warnings and 4165 errors.

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1704 tests and 10633 assertions.
Checkstyle analysis reported 235 warnings and 0 errors.

Build triggered by changes to the base.

Test log missing. Tests failed to execute.
Checkstyle analysis reported 235 warnings and 0 errors.

Build triggered by changes to the head.

Unit testing complete. There were 0 failures and 0 errors from 1735 tests and 10781 assertions.
Checkstyle analysis reported 235 warnings and 0 errors.

eddieajau added a commit that referenced this pull request Nov 24, 2011

Merge pull request #310 from realityking/controller
Fix a regression with controllers for specific formats.

@eddieajau eddieajau merged commit 5ec800a into joomla:staging Nov 24, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment