This repository has been archived by the owner on Nov 26, 2017. It is now read-only.
Calling JResponse::setHeader with $replace = false more than once with th #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the same name correctly adds multiple entries to the self::$headers array. But JResponse::sendHeaders would then always replace earlier headers of the same name because the 2nd argument to the PHP header function defaults to true, not false.
LouisLandry
added a commit
that referenced
this pull request
Sep 11, 2011
Calling JResponse::setHeader with $replace = false more than once with th
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling JResponse::setHeader with $replace = false more than once with the same name correctly adds multiple entries to the self::$headers array. But JResponse::sendHeaders would then always replace earlier headers of the same name because the 2nd argument to the PHP header function defaults to true, not false.