Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Minor improvements to error reporting #367

Merged
merged 6 commits into from Oct 15, 2011

Conversation

Projects
None yet
4 participants
Contributor

eddieajau commented Sep 16, 2011

Replaced usage of JException with Exception in the Application package. Added unit test to verify exception is thrown.
Fixed a problem in JError where an infinite loop is detected (defers to the echo handler).
Added a check in the custom error page handler for if the document body is empty, defer to the echo handler otherwise no error will display at all.

eddieajau added some commits Sep 16, 2011

Changes the infinite loop check in JError::throwError do default to the
echo handler and display the message rather than giving an undescriptive
message.
Add ability for JError echo handler to display a backtrace.
If the document body is empty for a custom error page, defer to the echo
handler.
Contributor

ianmacl commented Sep 17, 2011

Test Results

Total Tests:
Assertions:
Failures:
Errors:
Test Time:

@chdemko chdemko commented on an outdated diff Sep 19, 2011

libraries/joomla/error/error.php
@@ -553,10 +579,18 @@ abstract class JError
if (defined('STDERR'))
{
fwrite(STDERR, "J$level_human: " . $error->get('message') . "\n");
+ if (constant('JDEBUG'))
+ {
+ frwite(STDERR, $trace);
@chdemko

chdemko Sep 19, 2011

Contributor

Should be fwrite instead of 'frwite'

LouisLandry added a commit that referenced this pull request Oct 15, 2011

Merge pull request #367 from eddieajau/deprecated
Minor improvements to error reporting

@LouisLandry LouisLandry merged commit 7ef60b9 into joomla:staging Oct 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment